Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collectibles loading performance #18608

Closed
Tracked by #18612
vkjr opened this issue Jan 24, 2024 · 1 comment · Fixed by #18921
Closed
Tracked by #18612

Collectibles loading performance #18608

vkjr opened this issue Jan 24, 2024 · 1 comment · Fixed by #18921
Assignees
@ulisesmac
Labels
wallet: Collectibles all issues for the collectibles page of the wallet

Comments

@vkjr
Copy link
Contributor

vkjr commented Jan 24, 2024

Problem

When account has a lot of collectibles collectibles (like sonnyf.eth), our interface load them inconsistently - they appear and disappear, order changes and that gives bad user experience.

Simulator Screenshot - iPhone 13 - 2024-01-24 at 14 25 33

That should be fixed.

Acceptance Criteria

Users shouldn't see collectibles blinking and changing the order while they are loaded
@vkjr vkjr added E:Mobile Wallet MVP wallet: Collectibles all issues for the collectibles page of the wallet labels Jan 24, 2024
@J-Son89 J-Son89 mentioned this issue Jan 24, 2024
Open
13 tasks
@ulisesmac
Copy link
Contributor

ulisesmac commented Jan 24, 2024 •
edited
Loading

Hey @vkjr
I believe the problem in this issue is not related to performance, it's about the order we are storing the collectibles (adding to the beggining instad of adding them to the end of the collection).

btw, I've just wrote an issue about some performance issues:

@ulisesmac ulisesmac self-assigned this Feb 6, 2024
@ulisesmac ulisesmac removed the blocked label Feb 19, 2024
@ulisesmac ulisesmac mentioned this issue Feb 20, 2024
Merged
ulisesmac added a commit that referenced this issue Mar 7, 2024
@ulisesmac
[#18608] Immprove collectibles fetching performance (#18921)
ad546f9 
* Add memoized versions to convert keys

* Add placeholder for SVG collectibles due to errors and warnings

* Add events to request collectibles per account

* Update subs to list all accounts collectibles evenly

* Update collectibles tab to pull new data when end is reached

* Use memoized version of key transformation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
wallet: Collectibles all issues for the collectibles page of the wallet
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#18608] Collectibles fetching performance status-im/status-mobile
2 participants
@vkjr @ulisesmac