Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix latestactive chats #12490

Closed
wants to merge 1 commit into from
Closed

fix latestactive chats #12490

wants to merge 1 commit into from

Conversation

flexsurfer
Copy link
Member

fix latestactive chats

@flexsurfer flexsurfer self-assigned this Aug 25, 2021
@Serhy Serhy self-assigned this Aug 25, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Aug 25, 2021 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fde338f #1 2021-08-25 09:19:22 ~16 min android-e2e 📦apk 📲
✔️ fde338f #1 2021-08-25 09:25:29 ~22 min ios 📦ipa 📲
✔️ fde338f #1 2021-08-25 09:27:22 ~24 min android 📦apk 📲
✔️ 1842164 #2 2021-08-25 13:36:26 ~19 min android-e2e 📦apk 📲
✔️ 1842164 #2 2021-08-25 13:37:59 ~21 min android 📦apk 📲
✔️ 1842164 #2 2021-08-25 13:38:23 ~21 min ios 📦ipa 📲

@Serhy
Copy link
Contributor

Serhy commented Aug 25, 2021

Tested with latest build and hundreds of chats: those chats with recent activity OR those which were at the end of list but received message - appears at the top of list after login and sorted accordingly to timestamp of activity in chat.
Thanks @flexsurfer
Could you fix conflicts please?

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 71
Failed tests: 5
Passed tests: 66

IDs of failed tests: 6305,6645,6263,6249,6237

Failed tests (5)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: *Find Button by accessibility id:* `send-my-status-button`
    Device 1: *Tap on found Button*

    Device 1: Status is not set

    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: *Tap on found MultiAccountOnLoginButton*
    Device 1: **Enter default pin 111111**

    Device 1: Keycard user is not logged in

    Device sessions

    3. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found Button*
    Device 2: *Wait for text element TransactionStatus to be equal to Pending*

    Device 2: 'Confirmed' is not equal to expected 'Pending' in 60 sec

    Device sessions

    4. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Find SignWithKeycardButton by xpath:* `//*[contains(@text,'Sign with')]`
    Device 1: **Enter default pin 111111**

    Device 1: Transaction failed; also Unexpected Alert is shown: 'replacement transaction underpriced'

    Device sessions

    5. test_fetching_balance_after_offline, id: 6237

    Device 1: *Find AirplaneModeButton by accessibility id:* `Airplane mode`
    Device 1: *Tap on found AirplaneModeButton*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 100 seconds

    Device sessions

    Passed tests (66)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    3. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    4. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    5. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    6. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    7. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    8. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    9. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    10. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    11. test_delete_close_all_tabs, id: 5390
    Device sessions

    12. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    13. test_send_token_with_7_decimals, id: 5350
    Device sessions

    14. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    15. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    16. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    17. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_block_user_from_public_chat, id: 5786
    Device sessions

    21. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    24. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    25. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    26. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    27. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    28. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    29. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    30. test_long_press_to_delete_chat, id: 5319
    Device sessions

    31. test_copy_and_paste_messages, id: 5317
    Device sessions

    32. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    33. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    34. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    35. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    36. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    37. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    38. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    40. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_can_add_existing_ens, id: 5502
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_set_profile_picture, id: 6646
    Device sessions

    57. test_collectible_from_wallet, id: 5346
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    60. test_pass_phrase_validation, id: 5363
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    62. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    63. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    64. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    65. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    66. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @flexsurfer
    Copy link
    Member Author

    @Serhy done

    @status-im-auto
    Copy link
    Member

    40% of end-end tests have passed

    Total executed tests: 5
Failed tests: 3
Passed tests: 2

    IDs of failed tests: 6305,6249,6263

    Failed tests (3)

    Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: *Find Button by accessibility id:* `send-my-status-button`
    Device 1: *Tap on found Button*

    Device 1: Status is not set

    Device sessions

    2. test_keycard_request_stt_from_daap, id: 6249

    Device 1: SilentButton element not found
    Device 1: **Enter default pin 111111**

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    3. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found Button*
    Device 2: *Wait for text element TransactionStatus to be equal to Pending*

    Device 2: 'Confirmed' is not equal to expected 'Pending' in 60 sec

    Device sessions

    Passed tests (2)

    Click to expand

    1. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    2. test_fetching_balance_after_offline, id: 6237
    Device sessions

    @status-im-auto
    Copy link
    Member

    87% of end-end tests have passed

    Total executed tests: 71
Failed tests: 9
Passed tests: 62

    IDs of failed tests: 6290,6293,6249,6279,5309,6263,6251,6305,6237

    Failed tests (9)

    Click to expand
  • Rerun tests

    • 1. test_keycard_fetching_balance_after_offline, id: 6290

    Device 1: *Find Button by accessibility id:* `mobile-network-continue-syncing`
    Device 1: *Tap on found Button*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 300 seconds

    Device sessions

    2. test_keycard_send_eth_in_1_1_chat, id: 6293

    Finding tx in ETH transactions, attempt #8
    Finding tx in ETH transactions, attempt #9

    Expecting value: line 1 column 1 (char 0)

    Device sessions

    3. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5677000.0 is not changed during 400 seconds!

    Device sessions

    4. test_send_eth_to_ens_in_chat, id: 6279

    Transaction #5, amount is 0.002572116
    {'blockNumber': '10905265', 'timeStamp': '1629876172', 'hash': '0x039a870191de98e40dd389fda8033bca27d8c0158e0c9157df524823a6bf0701', 'nonce': '6121', 'blockHash': '0x1a1af9f653817711452400cd8c0bd4ce18642cd6b6bb51b524b9327d60a0cf2e', 'transactionIndex': '0', 'from': '0xf7cb60839c0de25e37be0391c33bb34a8f0f8414', 'to': '0x8ef5538499b7ab1bba1cc24168ac61afdb7b41e0', 'value': '2572116000000000', 'gas': '21000', 'gasPrice': '2499999975', 'isError': '0', 'txreceipt_status': '1', 'input': '0x', 'contractAddress': '', 'cumulativeGasUsed': '21000', 'gasUsed': '21000', 'confirmations': '1813'}

    Transaction with amount 0.002514253 is not found in list of ETH transactions, address is f7cb60839c0de25e37be0391c33bb34a8f0f8414 during 300s

    Device sessions

    5. test_request_stt_from_daap, id: 5309

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5677000.0 is not changed during 400 seconds!

    Device sessions

    6. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found Button*
    Device 2: *Wait for text element TransactionStatus to be equal to Pending*

    Device 2: 'Confirmed' is not equal to expected 'Pending' in 60 sec

    Device sessions

    7. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: SilentButton element not found
    Device 1: **Enter default pin 111111**

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    8. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: *Find Button by accessibility id:* `send-my-status-button`
    Device 1: *Tap on found Button*

    Device 1: Status is not set

    Device sessions

    9. test_fetching_balance_after_offline, id: 6237

    Transaction #5, amount is 0.002512858
    {'blockNumber': '10906577', 'timeStamp': '1629893426', 'hash': '0x26e4adac5c9f220f665a38c5f6edf7c447a28ab293da4c256c91d8538a028c3a', 'nonce': '2463', 'blockHash': '0x880aef790225ea6c7171f2eec910de0f00579f9129f6b660fbd95fec83a0333f', 'from': '0xa94a2a7584620677d290549a96046e59a18f09ef', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '2512858000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '10', 'gas': '125182', 'gasPrice': '5703570855', 'gasUsed': '104319', 'cumulativeGasUsed': '3927831', 'input': 'deprecated', 'confirmations': '609'}

    Transaction with amount 0.0025143016 is not found in list of token transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D during 300s

    Device sessions

    Passed tests (62)

    Click to expand

    1. test_send_token_with_7_decimals, id: 5350
    Device sessions

    2. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    3. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    4. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    5. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    6. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    7. test_long_press_to_delete_chat, id: 5319
    Device sessions

    8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    9. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    10. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    11. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    12. test_manage_assets, id: 5341
    Device sessions

    13. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    14. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    15. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    16. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    17. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    18. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    19. test_browser_managing_bookmarks, id: 6633
    Device sessions

    20. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    21. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    22. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    23. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    25. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    26. test_dapps_permissions, id: 5738
    Device sessions

    27. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    28. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    29. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    30. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    31. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    32. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    33. test_delete_close_all_tabs, id: 5390
    Device sessions

    34. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    35. test_block_user_from_public_chat, id: 5786
    Device sessions

    36. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    37. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    38. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    39. test_home_view, id: 5379
    Device sessions

    40. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    41. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    42. test_set_profile_picture, id: 6646
    Device sessions

    43. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    44. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    45. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    46. test_can_add_existing_ens, id: 5502
    Device sessions

    47. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    48. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    49. test_copy_and_paste_messages, id: 5317
    Device sessions

    50. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    51. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    52. test_pass_phrase_validation, id: 5363
    Device sessions

    53. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    54. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    55. test_wallet_set_up, id: 5335
    Device sessions

    56. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    57. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_collectible_from_wallet, id: 5346
    Device sessions

    60. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    61. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    62. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    @Serhy
    Copy link
    Contributor

    Serhy commented Aug 25, 2021

    There is a bug with Status tab:
    The first post in timeline won't be visible on Status tab. You send post - but nothing appears on Status view. Second and rest posts are visible fine. However only after re-login the first post will be visible.
    To reproduce:

    1. Create new account
    2. Open Status tab
    3. Send message (post)
    2021_08_25_18_01_47_trim.mp4

    @flexsurfer flexsurfer closed this Aug 26, 2021
    @jakubgs jakubgs deleted the bug/fix-active-chats branch September 21, 2022 17:36
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @shivekkhurana shivekkhurana shivekkhurana approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    Assignees

    @Serhy Serhy

    @flexsurfer flexsurfer

    Labels
    request-manual-qa Tested - Issues
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @flexsurfer @status-im-auto @Serhy @shivekkhurana @briansztamfater