[#15719] Recovery phrase input #15720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
ulisesmac
commented
Apr 23, 2023
| (:require [quo2.components.inputs.recovery-phrase.view :as recovery-phrase] | ||
| [test-helpers.component :as h])) | ||
|
|
||
| (h/describe "Recovery phrase input" |
There was a problem hiding this comment.
Unfortunately, I couldn't manage to test the content of this input since the text inside the input are its children, It was not easy and it was taking some time, I'll be off some days, so in order to merge this I created an issue to track it: #15721
ilmotta
approved these changes
Apr 24, 2023
src/status_im2/contexts/quo_preview/inputs/recovery_phrase_input.cljs
Outdated
Show resolved
Hide resolved
cammellos
force-pushed
the
15719-recovery-phrase-input
branch
from
6ad944c
to
e676b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue adds the recovery phrase input.
Designs: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=19591-239976&t=psVx1EXFPrTRVQLR-4
fixes #15719
Summary
Review notes
Nesting views into text-inputs is not supported, so I wasn't able to add the padding & border-radius present in designs when a word has an error:
Platforms
Areas that maybe impacted
Onboarding seed phrase screen
Steps to test:
status: ready