Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always albumize outgoing image messages #15735

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Apr 25, 2023

partial fix for #15657, can't reproduce image failing to load

Summary

always albumize outgoing image messages

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Apr 25, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 61aef9e #1 2023-04-25 08:55:30 ~5 min android-e2e 🤖apk 📲
✔️ 61aef9e #1 2023-04-25 08:56:17 ~6 min android 🤖apk 📲
✔️ 61aef9e #1 2023-04-25 08:56:24 ~6 min ios 📱ipa 📲
✔️ 61aef9e #1 2023-04-25 08:56:31 ~6 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2e7c820 #2 2023-04-25 15:26:53 ~7 min ios 📱ipa 📲
✔️ 2e7c820 #2 2023-04-25 15:27:00 ~7 min tests 📄log
✔️ 2e7c820 #2 2023-04-25 15:27:20 ~7 min android 🤖apk 📲
✔️ 2e7c820 #2 2023-04-25 15:28:47 ~8 min android-e2e 🤖apk 📲
✔️ 0d584ef #3 2023-04-26 01:53:53 ~5 min android-e2e 🤖apk 📲
✔️ 0d584ef #3 2023-04-26 01:54:09 ~5 min android 🤖apk 📲
✔️ 0d584ef #3 2023-04-26 01:54:11 ~5 min tests 📄log
✔️ 0d584ef #3 2023-04-26 01:54:46 ~6 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

48% of end-end tests have passed

Total executed tests: 25
Failed tests: 13
Passed tests: 12
Not executed tests: 4
IDs of not executed tests: 702846,702742,702850,702851 
IDs of failed tests: 702947,702840,702958,702844,702786,702894,702845,702841,702936,702957,702839,702838,702843 

Not executed tests (4)

Click to expand
  • Rerun not executed tests
  • Failed tests (13)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    3. test_community_mentions_push_notification, id: 702786

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    4. test_community_contact_block_unblock_offline, id: 702894

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    5. test_community_leave, id: 702845

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    6. test_community_unread_messages_badge, id: 702841

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    7. test_community_message_delete, id: 702839

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find CheckBox by accessibility id: checkbox-off
    Device 2: Find CheckBox by accessibility id: checkbox-off

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen 
    

    [[blocked by 14797]]

    Device sessions

    9. test_community_message_edit, id: 702843

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Test setup failed: medium/test_activity_center.py:228: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    2. test_activity_center_admin_notification_accept_swipe, id: 702958

    Test setup failed: medium/test_activity_center.py:228: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen 
    

    [[Blocked by 15500]]

    3. test_navigation_jump_to, id: 702936

    Device 2: Find CheckBox by accessibility id: checkbox-off
    Device 2: Find CheckBox by accessibility id: checkbox-off

    Test setup failed: medium/test_activity_center.py:228: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    Device sessions

    4. test_activity_center_mentions, id: 702957

    Test setup failed: medium/test_activity_center.py:228: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen 
    

    [[Blocked by 15500]]

    Passed tests (12)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Signed-off-by: yqrashawn <namy.19@gmail.com>
    @yqrashawn yqrashawn merged commit f9eae4e into develop Apr 26, 2023
    @yqrashawn yqrashawn deleted the albumize-outgoing-messages branch April 26, 2023 06:26
    @status-im-auto
    Copy link
    Member

    48% of end-end tests have passed

    Total executed tests: 25
    Failed tests: 13
    Passed tests: 12
    Not executed tests: 4
    
    IDs of not executed tests: 702846,702742,702850,702851 
    
    IDs of failed tests: 702947,702840,702958,702844,702786,702894,702845,702841,702936,702957,702839,702838,702843 
    

    Not executed tests (4)

    Click to expand
  • Rerun not executed tests
  • Failed tests (13)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    3. test_community_mentions_push_notification, id: 702786

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    4. test_community_contact_block_unblock_offline, id: 702894

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    5. test_community_leave, id: 702845

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    6. test_community_unread_messages_badge, id: 702841

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    7. test_community_message_delete, id: 702839

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    8. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find CheckBox by accessibility id: checkbox-off
    Device 2: Find CheckBox by accessibility id: checkbox-off

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen 
    

    [[blocked by 14797]]

    Device sessions

    9. test_community_message_edit, id: 702843

    Test setup failed: critical/test_public_chat_browsing.py:397: in prepare_devices
        self.community_2.join_community()
    ../views/chat_view.py:372: in join_community
        self.checkbox_button.scroll_and_click()
    ../views/base_element.py:182: in scroll_and_click
        self.scroll_to_element(direction=direction)
    ../views/base_element.py:177: in scroll_to_element
        raise NoSuchElementException(
     Device 2: CheckBox by accessibility id: `checkbox-off` is not found on the screen
    



    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Test setup failed: medium/test_activity_center.py:191: in prepare_devices
        users = self.loop.run_until_complete(run_in_parallel(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:36: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/base_view.py:622: in get_public_key_and_username
        default_username = profile_view.default_username_text.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Text by accessibility id: `default-username` is not found on the screen
    



    2. test_activity_center_admin_notification_accept_swipe, id: 702958

    Test setup failed: medium/test_activity_center.py:191: in prepare_devices
        users = self.loop.run_until_complete(run_in_parallel(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:36: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/base_view.py:622: in get_public_key_and_username
        default_username = profile_view.default_username_text.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Text by accessibility id: `default-username` is not found on the screen 
    

    [[Blocked by 15500]]

    3. test_navigation_jump_to, id: 702936

    Device 1: Text is zQ3shgWCsZgNvBYEHxSLaRem9geDUE4qLcAe61WgMZzKsP3RZ
    Device 1: Click system back button

    Test setup failed: medium/test_activity_center.py:191: in prepare_devices
        users = self.loop.run_until_complete(run_in_parallel(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:36: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/base_view.py:622: in get_public_key_and_username
        default_username = profile_view.default_username_text.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Text by accessibility id: `default-username` is not found on the screen
    



    Device sessions

    4. test_activity_center_mentions, id: 702957

    Test setup failed: medium/test_activity_center.py:191: in prepare_devices
        users = self.loop.run_until_complete(run_in_parallel(
    /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
        return future.result()
    __init__.py:36: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/base_view.py:622: in get_public_key_and_username
        default_username = profile_view.default_username_text.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Text by accessibility id: `default-username` is not found on the screen 
    

    [[Blocked by 15500]]

    Passed tests (12)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    5 participants