On password creation screen make the password disclaimer tappable #15757

siddarthkay · 2023-04-26T11:57:25Z

This PR solves a tiny UX issue on password creation screens.
Currently the password disclaimer is a tiny checkbox which has a very small tappable area :

This PR makes the entire row tappable so that its easier for the users to just tap the disclaimer and move forward.

Screen.Recording.2023-04-26.at.5.25.51.PM.mov

Platforms

Android
iOS

Areas that maybe impacted

Onboarding

fixes : #15662

status: ready

src/status_im2/contexts/onboarding/create_password/view.cljs

status-im-auto · 2023-04-26T12:04:58Z

Jenkins Builds

Click to see older builds (31)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e0f61d4`	#2	2023-04-26 12:04:57	~6 min	`android`	🤖`apk` 📲
✔️	`e0f61d4`	#2	2023-04-26 12:05:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`e0f61d4`	#2	2023-04-26 12:06:28	~7 min	`tests`	📄`log`
✔️	`e0f61d4`	#2	2023-04-26 12:43:18	~44 min	`ios`	📱`ipa` 📲

✔️	`b7cca93`	#4	2023-04-27 11:27:17	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`b7cca93`	#4	2023-04-27 11:28:14	~12 min	`android`	🤖`apk` 📲
❌	`b7cca93`	#4	2023-04-27 11:31:03	~15 min	`tests`	📄`log`
✔️	`b7cca93`	#4	2023-04-27 12:15:12	~59 min	`ios`	📱`ipa` 📲

✔️	`8cc238c`	#6	2023-04-28 02:49:26	~5 min	`android`	🤖`apk` 📲
✔️	`8cc238c`	#6	2023-04-28 02:50:31	~6 min	`android-e2e`	🤖`apk` 📲
❌	`8cc238c`	#6	2023-04-28 02:50:44	~6 min	`tests`	📄`log`
✔️	`8cc238c`	#6	2023-04-28 02:51:41	~7 min	`ios`	📱`ipa` 📲

✔️	`a50f364`	#7	2023-04-28 09:27:34	~5 min	`android`	🤖`apk` 📲
✔️	`a50f364`	#7	2023-04-28 09:28:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a50f364`	#7	2023-04-28 09:28:34	~6 min	`ios`	📱`ipa` 📲
❌	`a50f364`	#7	2023-04-28 09:28:41	~6 min	`tests`	📄`log`

✔️	`cad2597`	#10	2023-04-28 10:15:33	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`cad2597`	#10	2023-04-28 10:16:45	~6 min	`android`	🤖`apk` 📲
❌	`cad2597`	#10	2023-04-28 10:16:57	~6 min	`tests`	📄`log`
✔️	`cad2597`	#10	2023-04-28 10:20:18	~10 min	`ios`	📱`ipa` 📲

❌	`ed28a7a`	#11	2023-04-29 08:34:18	~3 min	`tests`	📄`log`
✔️	`ed28a7a`	#11	2023-04-29 08:36:35	~5 min	`android`	🤖`apk` 📲
✔️	`ed28a7a`	#11	2023-04-29 08:36:46	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`ed28a7a`	#11	2023-04-29 08:37:56	~6 min	`ios`	📱`ipa` 📲

❌	`19075b3`	#12	2023-04-29 10:00:36	~3 min	`tests`	📄`log`
✔️	`19075b3`	#12	2023-04-29 10:02:55	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`19075b3`	#12	2023-04-29 10:02:59	~5 min	`android`	🤖`apk` 📲

✔️	`427cd22`	#13	2023-04-29 10:08:50	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`427cd22`	#13	2023-04-29 10:09:17	~5 min	`tests`	📄`log`
✔️	`427cd22`	#13	2023-04-29 10:09:28	~6 min	`ios`	📱`ipa` 📲
✔️	`427cd22`	#13	2023-04-29 10:09:51	~6 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7bfd367`	#15	2023-05-01 17:32:43	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`7bfd367`	#15	2023-05-01 17:33:09	~6 min	`ios`	📱`ipa` 📲
✔️	`7bfd367`	#15	2023-05-01 17:33:14	~6 min	`android`	🤖`apk` 📲
✔️	`7bfd367`	#15	2023-05-01 17:33:35	~6 min	`tests`	📄`log`

✔️	`6f9fdef`	#17	2023-05-02 10:21:48	~5 min	`tests`	📄`log`
✔️	`6f9fdef`	#17	2023-05-02 10:21:54	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`6f9fdef`	#17	2023-05-02 10:22:19	~6 min	`android`	🤖`apk` 📲
✔️	`6f9fdef`	#17	2023-05-02 10:22:31	~6 min	`ios`	📱`ipa` 📲

siddarthkay · 2023-04-28T02:58:41Z

Oh i broke component test 😅

[2023-04-28T02:50:12.500Z] FAIL component-spec/quo2.components.selectors.disclaimer.component_spec.js
[2023-04-28T02:50:12.500Z]   ● Disclaimer tests › On change event gets fire after press
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]     expect(jest.fn()).toHaveBeenCalled()
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]     Expected number of calls: >= 1
[2023-04-28T02:50:12.500Z]     Received number of calls:    0
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]       at mock-fn (test_helpers/component.cljs:192:33)
[2023-04-28T02:50:12.500Z]       at Object.<anonymous> (quo2/components/selectors/disclaimer/
component_spec.cljs:19:21)
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]   ● Disclaimer tests › It's rendered according to its `checked?` 
property › checked? true
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]     expect(received).toBeNull()
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.500Z]     Received: {"_fiber": {"_debugHookTypes": null, "_debugID": 112,
 "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, 
 "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, 
 "dependencies": null, "elementType": "View", "firstEffect": null, "flags": 0, "index": 0, "key": null, 
 "lanes": 0, "lastEffect": null, "memoizedProps": [Object], "memoizedState": null, "mode": 0, 
 "nextEffect": null, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, 
 "sibling": null, "stateNode": [Object], "tag": 5, "treeBaseDuration": 0, "type": "View", 
 "updateQueue": null}}
[2023-04-28T02:50:12.500Z] 
[2023-04-28T02:50:12.501Z]       at test-helpers.component/query-by-label-text 
(test_helpers/component.cljs:188:25)
[2023-04-28T02:50:12.501Z]       at Object.<anonymous> (quo2/components/selectors/disclaimer/
component_spec.cljs:24:19)

ajayesivan · 2023-04-28T08:29:32Z

@siddarthkay Related issue: #15662

J-Son89 · 2023-04-28T08:47:51Z

@siddarthkay Related issue: #15662

@siddarthkay Can you update the description with the related issue?

status-im-auto · 2023-04-29T10:25:36Z

0% of end-end tests have passed

Total executed tests: 7
Failed tests: 7
Passed tests: 0
Not executed tests: 23

IDs of not executed tests: 702730,702782,702731,702745,702813,702855,702733,702783,702784,702838,702843,702839,702840,702841,702844,702894,702845,702786,703086,702846,702742,702850,702851

IDs of failed tests: 702947,702958,702732,702807,702936,702957,702808

Not executed tests (23)

Click to expand

Rerun not executed tests

Failed tests (7)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element
2. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: Tap on found: Button Device 2: Wait for element `Button` for max 30s and click when it is available Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:154: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: medium/test_activity_center.py:118: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: medium/test_activity_center.py:118: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element
3. test_navigation_jump_to, id: 702936
Device 2: Tap on found: Button Device 2: Wait for element `Button` for max 30s and click when it is available Test setup failed: medium/test_activity_center.py:118: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_activity_center_mentions, id: 702957
Test setup failed: medium/test_activity_center.py:118: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete return future.result() __init__.py:36: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:215: in create_user self.enable_biometric_maybe_later_button.wait_and_click(30) ../views/base_element.py:403: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by xpath:`//[@text="Maybe later"]` is not found on the screen after wait_for_visibility_of_element

pavloburykh · 2023-05-01T11:57:52Z

@siddarthkay thanx for the PR. Please take a look at the following issue

ISSUE 1 Confirm password button remains inactive after checking password disclaimer

Steps:

Proceed to password creation screen
Enter valid password
Check the disclaimer
See if confirm password button is active

Actual result: Confirm password button remains inactive after checking password disclaimer. Unable to proceed with creation of multiaccount

telegram-cloud-document-2-5368497275033104331.mp4

Expected result: Confirm password button is active. User is able to proceed to the next step.

siddarthkay · 2023-05-01T17:44:09Z

@pavloburykh : Thanks for testing and finding the grave issue.
Issue 1 is now fixed!

status-im-auto · 2023-05-02T06:59:20Z

87% of end-end tests have passed

Total executed tests: 30
Failed tests: 4
Passed tests: 26

IDs of failed tests: 703086,702894,702838,702850

Failed tests (4)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_mark_all_messages_as_read, id: 703086
Device 1: Find `Button` by `accessibility id`: `mark-as-read` Device 1: Tap on found: Button `critical/test_public_chat_browsing.py:645: in test_community_mark_all_messages_as_read self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter is not shown in home > Commmunity element` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_contact_block_unblock_offline, id: 702894
Device 2: Tap on found: SendMessageButton Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:624: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not received in 1-1 chat after user unblock!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:410: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:927: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Find Button by accessibility id: close-activity-center
Device 2: Tap on found: Button

medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Passed tests (26)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

pavloburykh · 2023-05-02T10:12:03Z

@siddarthkay thanx for the fix. Ready to be merged. Failed e2e are not PR related.

siddarthkay self-assigned this Apr 26, 2023

siddarthkay requested review from Parveshdhull, ulisesmac and cammellos April 26, 2023 11:57

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch from ce0cf0c to e0f61d4 Compare April 26, 2023 11:58

cammellos reviewed Apr 26, 2023

View reviewed changes

src/status_im2/contexts/onboarding/create_password/view.cljs Outdated Show resolved Hide resolved

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch from b807a38 to b7cca93 Compare April 27, 2023 11:15

siddarthkay requested review from J-Son89 and cammellos April 27, 2023 11:16

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch 2 times, most recently from ce71bdc to 8cc238c Compare April 28, 2023 02:43

J-Son89 mentioned this pull request Apr 28, 2023

The 'I understand that my password cannot be recovered' consent checkbox clickable area is too small #15662

Closed

J-Son89 approved these changes Apr 28, 2023

View reviewed changes

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch 4 times, most recently from 19075b3 to 427cd22 Compare April 29, 2023 10:03

siddarthkay added the request-manual-qa label Apr 29, 2023

pavloburykh self-assigned this May 1, 2023

pavloburykh added the Tested - Issues label May 1, 2023

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch from 6b7e27f to 7bfd367 Compare May 1, 2023 17:26

pavloburykh added Tested - OK and removed Tested - Issues labels May 2, 2023

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch from 7bfd367 to fd1fed2 Compare May 2, 2023 10:15

(fix) modify disclaimer component for on tap UX

6f9fdef

siddarthkay force-pushed the make-password-disclaimer-row-tappable branch from fd1fed2 to 6f9fdef Compare May 2, 2023 10:15

siddarthkay merged commit fac3685 into develop May 2, 2023

siddarthkay deleted the make-password-disclaimer-row-tappable branch May 2, 2023 10:25

pavloburykh mentioned this pull request May 3, 2023

Tapping Request to Join community disclaimer does not result disclaimer checkbox update #15803

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On password creation screen make the password disclaimer tappable #15757

On password creation screen make the password disclaimer tappable #15757

siddarthkay commented Apr 26, 2023 •

edited

Loading

status-im-auto commented Apr 26, 2023 •

edited

Loading

siddarthkay commented Apr 28, 2023 •

edited

Loading

ajayesivan commented Apr 28, 2023

J-Son89 commented Apr 28, 2023

status-im-auto commented Apr 29, 2023

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 1, 2023 •

edited

Loading

siddarthkay commented May 1, 2023

status-im-auto commented May 2, 2023

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 2, 2023

On password creation screen make the password disclaimer tappable #15757

On password creation screen make the password disclaimer tappable #15757

Conversation

siddarthkay commented Apr 26, 2023 • edited Loading

Platforms

Areas that maybe impacted

status-im-auto commented Apr 26, 2023 • edited Loading

Jenkins Builds

siddarthkay commented Apr 28, 2023 • edited Loading

ajayesivan commented Apr 28, 2023

J-Son89 commented Apr 28, 2023

status-im-auto commented Apr 29, 2023

0% of end-end tests have passed

Not executed tests (23)

Failed tests (7)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 1, 2023 • edited Loading

ISSUE 1 Confirm password button remains inactive after checking password disclaimer

siddarthkay commented May 1, 2023

status-im-auto commented May 2, 2023

87% of end-end tests have passed

Failed tests (4)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Passed tests (26)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 2, 2023

siddarthkay commented Apr 26, 2023 •

edited

Loading

status-im-auto commented Apr 26, 2023 •

edited

Loading

siddarthkay commented Apr 28, 2023 •

edited

Loading

pavloburykh commented May 1, 2023 •

edited

Loading