Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dissmiss all overlays #15773

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Improve dissmiss all overlays #15773

merged 1 commit into from
Apr 28, 2023

Conversation

Parveshdhull
Copy link
Member

fixes: #15771

Summary

There are too many overlay views, and all have their own effects for closing.
So function like dismissAllOverlays is not enough.

Testing

Please test theme changes with all overlay types

  • bottom sheet (messaging & communities, they use different overlays)
  • popover like chat qr code
  • visibility status popover
  • toasts (Quo preview can be used for creating toast)

@Parveshdhull Parveshdhull self-assigned this Apr 27, 2023
Parveshdhull
Parveshdhull commented Apr 27, 2023
View reviewed changes
src/status_im2/navigation/events.cljs
Comment on lines +148 to +149
[:hide-bottom-sheet]
[:bottom-sheet-hidden]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For dismissing bottom sheet, we also need to dispatch :bottom-sheet-hidden after hide-bottom-sheet this was causing the original issue #15771

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its weird we have to dispatch two separate events

@status-im-auto
Copy link
Member

status-im-auto commented Apr 27, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5fb86cc #1 2023-04-27 17:55:56 ~5 min android-e2e 🤖apk 📲
✔️ 5fb86cc #1 2023-04-27 17:57:17 ~7 min ios 📱ipa 📲
✔️ 5fb86cc #1 2023-04-27 17:57:25 ~7 min tests 📄log
✔️ 5fb86cc #1 2023-04-27 17:57:28 ~7 min android 🤖apk 📲
✔️ 0a8bca4 #2 2023-04-28 15:20:03 ~5 min android-e2e 🤖apk 📲
✔️ 0a8bca4 #2 2023-04-28 15:20:29 ~5 min android 🤖apk 📲
✔️ 0a8bca4 #2 2023-04-28 15:21:13 ~6 min tests 📄log
✔️ 0a8bca4 #2 2023-04-28 15:24:14 ~9 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27
Not executed tests: 1

IDs of not executed tests: 703086 

IDs of failed tests: 702850,702838

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    medium/test_activity_center.py:138: in test_activity_center_contact_request_decline
    if self.home_2.pending_contact_request_text.text != '1':
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen

    [[Blocked by 15500]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    @qoqobolo qoqobolo self-assigned this Apr 28, 2023
    @qoqobolo
    Copy link
    Contributor

    LGTM 👀
    Thanks @Parveshdhull, PR can be merged.

    @Parveshdhull Parveshdhull merged commit 9a8354f into develop Apr 28, 2023
    @Parveshdhull Parveshdhull deleted the fix/bottom-sheet-theme branch April 28, 2023 15:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    Assignees

    @Parveshdhull Parveshdhull

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Bottom sheets stop opening after changing device theme
    4 participants
    @Parveshdhull @status-im-auto @qoqobolo @flexsurfer