Quo2 Wallet: network bridge #16793
Merged
Quo2 Wallet: network bridge #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
force-pushed
the
quo2/network-bridge
branch
from
7b14158
to
e6862e6
Compare
OmarBasem
requested review from
rahulpsingh,
vkjr,
smohamedjavid,
J-Son89 and
mmilad75
Jenkins BuildsClick to see older builds (16)
|
J-Son89
reviewed
Jul 27, 2023
J-Son89
reviewed
Jul 27, 2023
J-Son89
reviewed
Jul 27, 2023
J-Son89
reviewed
Jul 27, 2023
|
a few screen shots of the preview screens would be great! :) |
ilmotta
reviewed
Jul 27, 2023
OmarBasem
force-pushed
the
quo2/network-bridge
branch
from
e6862e6
to
3fc1acc
Compare
vkjr
approved these changes
Jul 28, 2023
Francesca-G
reviewed
Jul 31, 2023
OmarBasem
force-pushed
the
quo2/network-bridge
branch
from
3fc1acc
to
d9b285f
Compare
|
Thanks for your review @Francesca-G :) I have replied to your comments on Figma |
Thank you for fixing the highlighted issues! About the size of the component, as you can see when I overlap the design with the implementation it doesn't match. Maybe it's a screen issue? 
the correct size should be 136x44px as you said |
|
@Francesca-G the scale would be different from device to device. |
Francesca-G
approved these changes
Aug 1, 2023
OmarBasem
force-pushed
the
quo2/network-bridge
branch
from
8ac9da2
to
1d0e36c
Compare
OmarBasem
force-pushed
the
quo2/network-bridge
branch
from
ad69401
to
9cc0963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16753
This PR implements Network Bridge component.
Designs.
Sceenshots: