Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for discovering local pairing peers #16803

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add support for discovering local pairing peers #16803

merged 1 commit into from
Jul 28, 2023

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Jul 28, 2023 •
edited
Loading

Summary

This PR initialises the status-go method startSearchForLocalPairingPeers which in turn will produce logs that are important for peer discovery while local pairing and will produce logs important to detect local pairing crashes.

Platforms

  • Android
  • iOS
Functional
  • Syncing

Steps to test

This PR does not require any testing.

status: ready

@siddarthkay siddarthkay self-assigned this Jul 28, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jul 28, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 3f78f2f #1 2023-07-28 07:07:30 ~3 min tests 📄log
✔️ 3f78f2f #1 2023-07-28 07:09:47 ~5 min android-e2e 🤖apk 📲
✔️ 3f78f2f #1 2023-07-28 07:10:02 ~5 min android 🤖apk 📲
✔️ 3f78f2f #1 2023-07-28 07:11:41 ~7 min ios 📱ipa 📲
✔️ d3e3f51 #2 2023-07-28 07:17:32 ~5 min android-e2e 🤖apk 📲
✔️ d3e3f51 #2 2023-07-28 07:18:57 ~6 min ios 📱ipa 📲
✔️ d3e3f51 #2 2023-07-28 07:20:09 ~7 min android 🤖apk 📲
✔️ d3e3f51 #2 2023-07-28 07:20:46 ~8 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 26876b3 #3 2023-07-28 08:40:10 ~5 min android-e2e 🤖apk 📲
✔️ 26876b3 #3 2023-07-28 08:41:11 ~6 min ios 📱ipa 📲
✔️ 26876b3 #3 2023-07-28 08:42:03 ~7 min android 🤖apk 📲
✔️ 26876b3 #3 2023-07-28 08:42:59 ~8 min tests 📄log
✔️ 0cc40fe #4 2023-07-28 09:47:21 ~5 min android 🤖apk 📲
✔️ 0cc40fe #4 2023-07-28 09:49:34 ~7 min android-e2e 🤖apk 📲
✔️ 0cc40fe #4 2023-07-28 09:50:16 ~8 min tests 📄log
✔️ 0cc40fe #4 2023-07-28 09:51:49 ~10 min ios 📱ipa 📲

@siddarthkay siddarthkay force-pushed the wire-up-local-pairing-peer-discovery branch from 3f78f2f to d3e3f51 Compare July 28, 2023 07:11
@siddarthkay siddarthkay added the syncing Syncing or pairing label Jul 28, 2023
smohamedjavid
smohamedjavid approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! These logs will help us a lot. 🚀

src/status_im/utils/universal_links/core.cljs Outdated Show resolved Hide resolved
@siddarthkay siddarthkay force-pushed the wire-up-local-pairing-peer-discovery branch from d3e3f51 to 26876b3 Compare July 28, 2023 08:34
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 40
Failed tests: 5
Passed tests: 35

IDs of failed tests: 702732,703133,702851,702745,702731

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find `MemberPhoto` by `xpath`: `//*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']`
    Device 2: Image differs from template to 6.378820082720588 percents 

    critical/chats/test_1_1_public_chats.py:1129: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Tap on found: Button
    Device 2: Find EditBox by accessibility id: profile-title-input 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.create_user(second_user=True, username=new_username)
../views/sign_in_view.py:234: in create_user
    self.set_profile(username)
../views/sign_in_view.py:218: in set_profile
    self.profile_your_name_edit_box.set_value(username)
../views/base_element.py:352: in set_value
    self.find_element().set_value(value)
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: EditBox by accessibility id: `profile-title-input` is not found on the screen



    Device sessions

    Passed tests (35)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    9. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @siddarthkay
    Copy link
    Contributor Author

    @status-im/mobile-qa : This PR does not require testing, I ran E2E, is it okay to merge now?

    @churik
    Copy link
    Member

    churik commented Jul 28, 2023

    sure, thank you for asking!

    @siddarthkay
    chore: wire up startSearchForLocalPairingPeers
    0cc40fe 
    This commit initialises the status-go method `startSearchForLocalPairingPeers` which in turn will produce logs that are important for peer discovery while local pairing and will produce logs important to detect local pairing crashes.
    @siddarthkay siddarthkay force-pushed the wire-up-local-pairing-peer-discovery branch from 26876b3 to 0cc40fe Compare July 28, 2023 09:41
    @siddarthkay siddarthkay merged commit 1c405d3 into develop Jul 28, 2023
    2 checks passed
    @siddarthkay siddarthkay deleted the wire-up-local-pairing-peer-discovery branch July 28, 2023 09:52
    @siddarthkay siddarthkay mentioned this pull request Jul 28, 2023
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @ajayesivan ajayesivan Awaiting requested review from ajayesivan

    Assignees

    @siddarthkay siddarthkay

    Labels
    syncing Syncing or pairing
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @siddarthkay @status-im-auto @churik @smohamedjavid