Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on-press prop to the collectable component #16837

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add on-press prop to the collectable component #16837

merged 1 commit into from
Aug 3, 2023

Conversation

smohamedjavid
Copy link
Member

@smohamedjavid smohamedjavid commented Aug 2, 2023 •
edited
Loading

fixes #16743

Summary

This PR adds the on-press prop required for navigating to other screens, such as the details screen, when we will start building screens.

Testing notes

This is a very minor functional update to the component.
Ref: #16743 (comment)

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Navigate to Quo2 Preview > profile > collectible
  • Tap on the collectable and check whether the alert is shown

status: ready

@smohamedjavid smohamedjavid self-assigned this Aug 2, 2023
@smohamedjavid smohamedjavid mentioned this pull request Aug 2, 2023
Closed
@smohamedjavid smohamedjavid marked this pull request as ready for review August 2, 2023 10:51
@status-im-auto
Copy link
Member

status-im-auto commented Aug 2, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6724a21 #2 2023-08-02 11:00:07 ~8 min ios 📱ipa 📲
✔️ 6724a21 #2 2023-08-02 11:01:11 ~9 min android-e2e 🤖apk 📲
✔️ 6724a21 #2 2023-08-02 11:01:36 ~9 min android 🤖apk 📲
✔️ 6724a21 #2 2023-08-02 11:01:52 ~9 min tests 📄log
✔️ d9ac3ca #3 2023-08-02 15:02:34 ~8 min ios 📱ipa 📲
✔️ d9ac3ca #3 2023-08-02 15:03:26 ~9 min android-e2e 🤖apk 📲
✔️ d9ac3ca #3 2023-08-02 15:03:39 ~9 min android 🤖apk 📲
✔️ d9ac3ca #3 2023-08-02 15:04:02 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 17c3b68 #4 2023-08-02 15:53:36 ~2 min tests 📄log
✔️ 17c3b68 #4 2023-08-02 15:57:28 ~6 min android-e2e 🤖apk 📲
✔️ 17c3b68 #4 2023-08-02 15:57:34 ~6 min android 🤖apk 📲
✔️ 17c3b68 #4 2023-08-02 15:58:54 ~7 min ios 📱ipa 📲
✔️ 17c3b68 #5 2023-08-02 16:07:10 ~8 min tests 📄log
✔️ f78773a #5 2023-08-03 08:54:01 ~6 min android-e2e 🤖apk 📲
✔️ f78773a #5 2023-08-03 08:54:06 ~6 min android 🤖apk 📲
✔️ f78773a #5 2023-08-03 08:54:33 ~6 min ios 📱ipa 📲
✔️ f78773a #6 2023-08-03 08:56:25 ~8 min tests 📄log

@smohamedjavid smohamedjavid force-pushed the feature/collectables-component branch 2 times, most recently from d9ac3ca to 17c3b68 Compare August 2, 2023 15:50
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 40
Failed tests: 5
Passed tests: 35
Not executed tests: 1

IDs of not executed tests: 702809 

IDs of failed tests: 702732,703133,703495,702745,702731

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find `MemberPhoto` by `xpath`: `//*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']`
    Device 2: Image differs from template to 6.209118412990196 percents 

    critical/chats/test_1_1_public_chats.py:1129: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chat name is not shown after unmute



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Passed tests (35)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_mentions_push_notification, id: 702786
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    12. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    6. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    9. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    @churik
    Copy link
    Member

    churik commented Aug 3, 2023

    small change on the existing component, which is not used in any screen yet.
    Approved to be merged.

    @smohamedjavid
    Update on-press on collectible
    f78773a 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid smohamedjavid merged commit cccf5ed into develop Aug 3, 2023
    2 checks passed
    @smohamedjavid smohamedjavid deleted the feature/collectables-component branch August 3, 2023 08:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @smohamedjavid smohamedjavid

    Labels
    request-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Implement Quo2 Profile/ Collectibles component
    4 participants
    @smohamedjavid @status-im-auto @churik @J-Son89