Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo2: Settings item blur #17258

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Quo2: Settings item blur #17258

merged 2 commits into from
Sep 12, 2023

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Sep 12, 2023 •
edited
Loading

This PR adds blur option for settings item component in preview screen.

It also adds a small improvement to the preview container. Many of the blur components have blur in dark mode only. An effect would need to be used to change to dark mode when changing blur in preview screen. This PR adds a blur-dark-only? option that can be passed to the preview container to change to dark theme automatically when setting blur.

@OmarBasem OmarBasem self-assigned this Sep 12, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 12, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dcfac48 #1 2023-09-12 11:10:35 ~7 min ios 📱ipa 📲
✔️ dcfac48 #1 2023-09-12 11:13:16 ~9 min android-e2e 🤖apk 📲
✔️ dcfac48 #1 2023-09-12 11:13:31 ~10 min android 🤖apk 📲
✔️ dcfac48 #1 2023-09-12 11:13:56 ~10 min tests 📄log
✔️ 20a6038 #2 2023-09-12 15:58:14 ~9 min android-e2e 🤖apk 📲
✔️ 20a6038 #2 2023-09-12 15:58:26 ~9 min android 🤖apk 📲
✔️ 20a6038 #2 2023-09-12 15:58:57 ~10 min tests 📄log
✔️ 20a6038 #2 2023-09-12 16:05:27 ~16 min ios 📱ipa 📲

clauxx
clauxx approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@clauxx clauxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarBasem
Copy link
Contributor Author

@Francesca-G a design review please :)

Francesca-G
Francesca-G approved these changes Sep 12, 2023
View reviewed changes
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmarBasem thank you for doing this, it makes it much easier to review and it's way more organized to check the different styles if a component only has dark blur or both :)

@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 43
Failed tests: 10
Passed tests: 33

IDs of failed tests: 702732,703086,702948,702894,702783,703503,702786,702731,702808,702958

Failed tests (10)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline
E    Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 1: Looking for activity center element: 'user_2'
    Device 1: Swiping right on element ActivityCenterElement 

    critical/test_public_chat_browsing.py:1243: in test_community_hashtag_links_to_community_channels
    reply_element.swipe_right_on_element()
../views/base_element.py:299: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:285: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:434: in find_element
    raise NoSuchElementException(
 Device 1: `ActivityCenterElement` by `xpath`:`//*[contains(@text, 'user_2')]/ancestor::*[@content-desc='activity']` not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:385: in test_activity_center_admin_notification_accept_swipe
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Passed tests (33)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @mohsen-ghafouri mohsen-ghafouri mentioned this pull request Sep 12, 2023
    Merged
    ilmotta
    ilmotta approved these changes Sep 12, 2023
    View reviewed changes
    Copy link
    Contributor

    @ilmotta ilmotta left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good idea @OmarBasem! Much better

    src/status_im2/contexts/quo_preview/preview.cljs
    [:f>
    (fn []
    (rn/use-effect (fn []
    (when blur-dark-only?
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    In theory it's recommended to add blur-dark-only? to the effect's dependency vector.

    @OmarBasem OmarBasem merged commit 344c9ba into develop Sep 12, 2023
    6 checks passed
    @OmarBasem OmarBasem deleted the quo2/settings-item-blur branch September 12, 2023 17:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    @clauxx clauxx clauxx approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @OmarBasem @status-im-auto @ilmotta @briansztamfater @clauxx @Francesca-G