Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17300] fix: syncing device indicator color and some alignment #17340

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[#17300] fix: syncing device indicator color and some alignment #17340

merged 1 commit into from
Sep 25, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #17300

fixed device indicator icon color and applied some alignment in setting item

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Sep 19, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 19, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8db3196 #2 2023-09-19 16:46:09 ~6 min android 🤖apk 📲
✔️ 8db3196 #2 2023-09-19 16:48:00 ~8 min ios 📱ipa 📲
✔️ 8db3196 #2 2023-09-19 16:50:08 ~10 min android-e2e 🤖apk 📲
✔️ 8db3196 #2 2023-09-19 16:53:30 ~13 min tests 📄log
✔️ 5aab66a #4 2023-09-25 08:51:14 ~9 min android-e2e 🤖apk 📲
✔️ 5aab66a #4 2023-09-25 08:51:31 ~9 min android 🤖apk 📲
✔️ 5aab66a #4 2023-09-25 08:52:04 ~10 min tests 📄log
✔️ 5aab66a #4 2023-09-25 08:55:22 ~13 min ios 📱ipa 📲

J-Son89
J-Son89 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the alignment of the icon! 🙌

@mohsen-ghafouri
Copy link
Contributor Author

@Francesca-G could you please check this?

@status-im-auto
Copy link
Member

79% of end-end tests have passed

Total executed tests: 43
Failed tests: 9
Passed tests: 34

IDs of failed tests: 702809,702784,702732,702894,702783,703503,702786,702731,702808

Failed tests (9)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1201: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 italic text in underscore is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    ## Sign in (password:qwerty1234, keycard:False)
    Device 2: Find EditBox by accessibility id: password-input 

    critical/chats/test_1_1_public_chats.py:1468: in test_1_1_chat_delete_via_long_press_relogin
    self.home_2.reopen_app()
../views/base_view.py:651: in reopen_app
    sign_in_view.sign_in(password)
../views/sign_in_view.py:296: in sign_in
    self.password_input.send_keys(password)
../views/base_element.py:367: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: EditBox by accessibility id: `password-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Passed tests (34)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    @pavloburykh pavloburykh self-assigned this Sep 21, 2023
    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Sep 21, 2023 •
    edited
    Loading

    @mohsen-ghafouri thank you for the PR!

    Regarding issues described here

    1. indicator icon color should be blur in dark them.
    2. current device doesn't have this device
    3. doesn't have indicator device icon

    As far as I see issues 2 and 3 are already addressed in latest develop.

    Here is screenshot from latest nightly build (Sep 21, 2023) taken on Android

    photo_2023-09-21 16 01 24

    Issue with icon color and alignment are addressed here.

    @mohsen-ghafouri from my side PR looks good. Though I am not sure if anything should be changed here in terms of:

    issues 2 and 3 are already addressed in latest develop.

    Moving PR to design review

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Thanks @pavloburykh , yes most of them already handled in another PR, i just fixed icon color and alignment here

    @mohsen-ghafouri
    Copy link
    Contributor Author

    @status-im/design-team could you please review this?

    Francesca-G
    Francesca-G approved these changes Sep 25, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Icon color and alignment looks good ✨

    Instead of my iPhone's name for the current device I get this "localhost" name:

    Screenshot 2023-09-25 alle 09 54 08

    I don't know if this is supposed to happen, thought I should let you know :)

    @mohsen-ghafouri
    Copy link
    Contributor Author

    mohsen-ghafouri commented Sep 25, 2023 •
    edited
    Loading

    thanks @Francesca-G ,yes i noticed about it and in my case it shows my local ip. i thought it's intentional in development.
    @pavloburykh please let me know if it has issue in release mode. we can create separate issue for that if needed

    @mohsen-ghafouri mohsen-ghafouri merged commit 848cac3 into develop Sep 25, 2023
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the fix/syncing-ui-mismatch branch September 25, 2023 08:55
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @mohsen-ghafouri @ibrkhalil
    [#17300] fix: syncing device indicator color and some alignment (#17340)
    179a413
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    follow up syncing screen device icon issue
    7 participants
    @mohsen-ghafouri @status-im-auto @pavloburykh @J-Son89 @jo-mut @Francesca-G @churik