Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback/default dimensions for Image sent from desktop #17966

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Nov 22, 2023

Fixes #17956

Uses fallback values for dimensions because image-width and image-height are not always available which is the reason for images to be displayed incorrectly or not displayed at all.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats

status: ready

@alwx alwx requested review from J-Son89 and jo-mut November 22, 2023 09:40
@alwx alwx self-assigned this Nov 22, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 22, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f535d97 #1 2023-11-22 09:47:13 ~6 min android-e2e 🤖apk 📲
✔️ f535d97 #1 2023-11-22 09:50:59 ~10 min android 🤖apk 📲
✔️ f535d97 #1 2023-11-22 09:52:07 ~11 min tests 📄log
✔️ f535d97 #1 2023-11-22 09:54:40 ~14 min ios 📱ipa 📲
✔️ db83f4b #2 2023-11-23 09:15:43 ~6 min android-e2e 🤖apk 📲
✔️ db83f4b #2 2023-11-23 09:16:11 ~6 min ios 📱ipa 📲
✔️ db83f4b #2 2023-11-23 09:18:51 ~9 min android 🤖apk 📲
✔️ db83f4b #2 2023-11-23 09:20:47 ~11 min tests 📄log

Copy link
Member

@Parveshdhull Parveshdhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alwx, Thank you for fixing this.

Detect image dimensions correctly

We still are not detecting image dimensions correctly, we are just adding fallback. Maybe a more relevant title would be "Add fallback/default dimensions for Image sent from desktop"

@Parveshdhull
Copy link
Member

Also, once status-im/status-desktop#10944 is merged, we can revert these changes.
(Please link this issue as a comment with above changes)

@alwx alwx changed the title Detect image dimensions correctly Add fallback/default dimensions for Image sent from desktop Nov 22, 2023
@alwx
Copy link
Contributor Author

alwx commented Nov 22, 2023

@Parveshdhull I don't think those changes need to be reverted even after the desktop changes are merged — it's good to have a fallback anyway just because we cannot ever be sure in other clients.

@churik
Copy link
Member

churik commented Nov 22, 2023

I checked it manually, worked for me, waiting for e2e - for some reason it fails on upload APK for testing. Restarted that manually

@churik
Copy link
Member

churik commented Nov 22, 2023

the issue with upload APK is not on the PR side, can merge and cherry-pick the PR to release branch, thank you!

@cammellos cammellos merged commit 671aa67 into develop Nov 23, 2023
2 checks passed
@cammellos cammellos deleted the bugfix/17956 branch November 23, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Images sent from desktop unavailable on mobile app
6 participants