fix: Cannot mark as read messages in communities

[qfrank]

fixes #18023

Platforms

• Android
• iOS

status: ready

[status-im-auto]

Jenkins Builds

Click to see older builds (13)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	30bacd1	#1	2023-11-30 03:38:43	~4 min	tests	📄log
✔️	30bacd1	#1	2023-11-30 03:40:40	~6 min	android-e2e	🤖apk 📲
✔️	30bacd1	#1	2023-11-30 03:42:21	~8 min	android	🤖apk 📲
✔️	30bacd1	#1	2023-11-30 03:49:17	~15 min	ios	📱ipa 📲
✔️	30bacd1	#2	2023-11-30 04:46:10	~10 min	tests	📄log
✔️	5c29638	#2	2023-11-30 12:23:02	~7 min	android-e2e	🤖apk 📲
✔️	5c29638	#2	2023-11-30 12:23:10	~7 min	ios	📱ipa 📲
✔️	5c29638	#2	2023-11-30 12:25:05	~9 min	android	🤖apk 📲
✔️	5c29638	#3	2023-11-30 12:27:36	~11 min	tests	📄log
✔️	241c004	#3	2023-12-01 08:39:42	~7 min	android-e2e	🤖apk 📲
✔️	241c004	#3	2023-12-01 08:39:55	~7 min	ios	📱ipa 📲
✔️	241c004	#3	2023-12-01 08:41:36	~8 min	android	🤖apk 📲
✔️	241c004	#4	2023-12-01 08:44:44	~12 min	tests	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	3e3af81	#4	2023-12-01 14:41:20	~6 min	android-e2e	🤖apk 📲
✔️	3e3af81	#4	2023-12-01 14:42:33	~7 min	ios	📱ipa 📲
✔️	3e3af81	#4	2023-12-01 14:44:46	~9 min	android	🤖apk 📲
✔️	3e3af81	#5	2023-12-01 14:46:42	~11 min	tests	📄log
✔️	a126c9a	#5	2023-12-02 00:48:40	~5 min	android-e2e	🤖apk 📲
✔️	a126c9a	#5	2023-12-02 00:51:34	~8 min	android	🤖apk 📲
✔️	a126c9a	#6	2023-12-02 00:53:47	~11 min	tests	📄log
✔️	a126c9a	#5	2023-12-02 00:56:53	~14 min	ios	📱ipa 📲

[status-im-auto]

81% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 4
Passed tests: 39

IDs of failed tests: 702777,703133,704613,702851,703629 

IDs of expected to fail tests: 702732,703503,702731,702808 

Failed tests (5)

Click to expand

Rerun failed tests

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613

Device 1: Find `Button` by `xpath`: `//*[@text="open community"]` Device 1: Tap on found: Button critical/test_deep_and_universal_links.py:56: in test_links_open_universal_links_from_chat self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Profile was not opened by the profile url https://status.app/u/G10A4B0JdgwyRww90WXtnP1oNH1ZLQNM0yX0Ja9YyAMjrqSZIYINOHCbFhrnKRAcPGStPxCMJDSZlGCKzmZrJcimHY8BbcXlORrElv_BbQEegnMDPx1g9C5VVNl0fE4y#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Tap on found: Button Device 2: Looking for community: 'open community' critical/chats/test_public_chat_browsing.py:1112: in test_community_join_when_node_owner_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Joined status is not displayed E open community is not listed inside Joined communities tab Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles Device 1: Tap on found: Button critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Incorrect contacts number restored: 0 instead of 2 E member_open was not restored from waku-backup!! E admin_closed was not restored from waku-backup!! E member_closed was not restored from waku-backup!! Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 2: Could not reach home view by pressing system back button Device 2: Find ChatsTab by accessibility id: chats-stack-tab activity_center/test_activity_center.py:142: in test_add_contact_field_validation self.home_2.profile_button.click() ../views/base_view.py:149: in click ChatsTab(self.driver).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 2: Tap on found: Button Device 2: Wait for element Button for max 30s and click when it is available activity_center/test_activity_center.py:93: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.device_2.create_user(username=new_username, first_user=False) ../views/sign_in_view.py:249: in create_user self.identifiers_button.wait_and_click(30) ../views/base_element.py:96: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (4)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732

Test is not run, e2e blocker [[reason: [NOTRUN] Pin feature is in development]]

2. test_group_chat_offline_pn, id: 702808

Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503

Test is not run, e2e blocker [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (39)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_one_image_send_reply, id: 702859

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_emoji_send_copy_paste_reply, id: 702840

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_mark_all_messages_as_read, id: 703086

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_community_contact_block_unblock_offline, id: 702894

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_community_message_delete, id: 702839

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_community_message_send_check_timestamps_sender_username, id: 702838

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

9. test_community_message_edit, id: 702843

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_community_unread_messages_badge, id: 702841

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_mute_chat, id: 703496

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions Device 1: Steps, video, logs

2. test_community_undo_delete_message, id: 702869

Device sessions Device 1: Steps, video, logs

3. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions Device 1: Steps, video, logs

4. test_community_mute_community_and_channel, id: 703382

Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_other_apps, id: 704614

Device sessions Device 1: Steps, video, logs

2. test_links_deep_links, id: 702775

Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

2. test_group_chat_send_image_save_and_share, id: 703297

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

3. test_group_chat_reactions, id: 703202

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

4. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_admin_notification_accept_swipe, id: 702958

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_community_hashtag_links_to_community_channels, id: 702948

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_community_mentions_push_notification, id: 702786

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_community_leave, id: 702845

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_1_1_chat_push_emoji, id: 702813

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_1_1_chat_edit_message, id: 702855

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

6. test_1_1_chat_send_image_save_and_share, id: 703391

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_1_1_chat_message_reaction, id: 702730

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[pavloburykh]

@qfrank thank you for the PR!

I have question regarding the description of this go PR which introduced the issue

According to the description:

Important changes:
1. Marking Mention or Reply AC notification as read (MarkAllActivityCenterNotificationsRead and MarkActivityCenterNotificationsRead) also marks corresponding message as seen
2. Marking message as seen (MarkMessagesSeen, MarkAllRead and MarkAllReadInCommunity) also marks corresponding AC notification as read

Point 2 Marking message as seen also marks corresponding AC notification as read works as described on mobile.

Point 1 Marking Mention or Reply AC notification as read also marks corresponding message as seen does not work as described on mobile. Marking AC notification as read does not affect correspondent message in chat. @qfrank do we need some additional changes on mobile side so it works as described? Can this part be included in this PR or it makes sense to work on this separately.

Below is the video showing current behaviour.

Status-debug-logs (86).zip

telegram-cloud-document-2-5424621648504438275.mp4

[qfrank]

@qfrank thank you for the PR!

I have question regarding the description of this go PR which introduced the issue

According to the description:

Important changes:
1. Marking Mention or Reply AC notification as read (MarkAllActivityCenterNotificationsRead and MarkActivityCenterNotificationsRead) also marks corresponding message as seen
2. Marking message as seen (MarkMessagesSeen, MarkAllRead and MarkAllReadInCommunity) also marks corresponding AC notification as read

Point 2 Marking message as seen also marks corresponding AC notification as read works as described on mobile.

Point 1 Marking Mention or Reply AC notification as read also marks corresponding message as seen does not work as described on mobile. Marking AC notification as read does not affect correspondent message in chat. @qfrank do we need some additional changes on mobile side so it works as described? Can this part be included in this PR or it makes sense to work on this separately.

Below is the video showing current behaviour.

Status-debug-logs (86).zip

telegram-cloud-document-2-5424621648504438275.mp4

i'll work on it in a separate PR @pavloburykh

[pavloburykh]

@qfrank thank you! PR is ready for merge

[pavloburykh]

i'll work on it in a separate PR @pavloburykh

Thank you @qfrank! I have created a ticket.