Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of :redef-in-file warning #18053

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: get rid of :redef-in-file warning #18053

merged 1 commit into from
Dec 4, 2023

Conversation

siddarthkay
Copy link
Contributor

make run-clojure would throw the following warning:

------ WARNING #1 - :redef-in-file ---------------------------------------------
 File: /Users/siddarthkumar/code/status-im/PR/status-mobile/src/quo/components/tags/tag.cljs:109:1
--------------------------------------------------------------------------------
 106 |        :labelled?           (if (= type :label) true labelled?)}
 107 |       [tag-resources size type resource icon-color label text-color labelled?]]]))
 108 |
 109 | (def tag (quo.theme/with-theme tag))
-------^------------------------------------------------------------------------
 tag at line 69 is being replaced
--------------------------------------------------------------------------------
 110 |
 111 |

This PR fixes that warning.

status: ready

@siddarthkay siddarthkay self-assigned this Dec 3, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Dec 3, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b01858b #1 2023-12-03 09:02:36 ~6 min android 🤖apk 📲
✔️ b01858b #1 2023-12-03 09:02:36 ~6 min android-e2e 🤖apk 📲
✔️ b01858b #1 2023-12-03 09:06:58 ~10 min tests 📄log
✔️ b01858b #1 2023-12-03 09:09:56 ~13 min ios 📱ipa 📲
✔️ c527bc7 #2 2023-12-04 08:40:53 ~6 min android-e2e 🤖apk 📲
✔️ c527bc7 #2 2023-12-04 08:41:36 ~7 min android 🤖apk 📲
✔️ c527bc7 #2 2023-12-04 08:46:00 ~11 min tests 📄log
✔️ c527bc7 #2 2023-12-04 08:48:21 ~13 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 4
Passed tests: 40

IDs of failed tests: 702777,702851,702850,703629 

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for a message by text: open community
    Device 2: Find `BaseElement` by `xpath`: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` 

    critical/chats/test_public_chat_browsing.py:1068: in test_community_join_when_node_owner_offline
    self.chat_2.chat_element_by_text(community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 2: Could not reach home view by pressing system back button
    Device 2: Find ChatsTab by accessibility id: chats-stack-tab 

    activity_center/test_activity_center.py:142: in test_add_contact_field_validation
    self.home_2.profile_button.click()
../views/base_view.py:149: in click
    ChatsTab(self.driver).click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    ## Creating new multiaccount (password:'qwerty1234', keycard:'False', enable_notification: 'False')
    Device 2: Find Button by accessibility id: show-new-account-options 

    activity_center/test_activity_center.py:93: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.create_user(username=new_username, first_user=False)
../views/sign_in_view.py:232: in create_user
    self.plus_profiles_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `show-new-account-options` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:63: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:406: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (40)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_open_universal_links_from_other_apps, id: 704614
    Device sessions

    3. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @siddarthkay
    Copy link
    Contributor Author

    @status-im/mobile-qa : we don't need to test this PR since it just fixes a minor clojure compiler warning.

    @siddarthkay siddarthkay merged commit 3cd302b into develop Dec 4, 2023
    6 checks passed
    @siddarthkay siddarthkay deleted the fix-quo-tag-warning branch December 4, 2023 08:48
    @ulisesmac
    Copy link
    Contributor

    @siddarthkay Thanks for this PR!

    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @siddarthkay @yevh-berdnyk
    fix: get rid of :redef-in-file warning (#18053)
    d072955
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @siddarthkay siddarthkay

    Labels
    developer-xp
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @siddarthkay @status-im-auto @ulisesmac @flexsurfer @Parveshdhull @ibrkhalil @ilmotta