chore(wallet): some minor cleanups, move sheets to appropriate level,… #18895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Son89
commented
Feb 19, 2024
| @@ -47,13 +47,6 @@ | |||
| (update-in [:wallet :ui :send] dissoc :route) | |||
| (update-in [:wallet :ui :send] dissoc :loading-suggested-routes?))})) | |||
|
|
|||
| (rf/reg-event-fx :wallet/select-send-account-address | |||
There was a problem hiding this comment.
this event was unused
J-Son89
force-pushed
the
jc/wallet-refactors-1
branch
from
44c4fae
to
4ed6d81
Compare
J-Son89
commented
Feb 19, 2024
| (rf/reg-event-fx :wallet/clean-send-address | ||
| (fn [{:keys [db]}] | ||
| {:db (update-in db [:wallet :ui :send] dissoc :recipient :to-address)})) | ||
|
|
||
| (rf/reg-event-fx | ||
| :wallet/select-send-address | ||
| (fn [{:keys [db]} [{:keys [address token recipient stack-id]}]] |
There was a problem hiding this comment.
a minor detail to this api to make it more readable, previously it looked as though we are using all of the token details in this endpoint
Jenkins BuildsClick to see older builds (8)
|
ulisesmac
approved these changes
Feb 19, 2024
smohamedjavid
approved these changes
Feb 19, 2024
OmarBasem
approved these changes
Feb 20, 2024
79% of end-end tests have passedFailed tests (9)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (38)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
|
|
hey @J-Son89 could you please rebase the current PR and resolve conflicts? thank you |
… remove unused rf event, improve one rf event api
J-Son89
force-pushed
the
jc/wallet-refactors-1
branch
from
1acfd31
to
1403ed4
Compare
|
@VolodLytvynenko - done! |
88% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hi @J-Son89 thank you for PR. no issues from my side. Ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is just a few small refactors.
I have:
moved the bottom sheets files in the wallet from
status-im.contexts.wallet.common.sheets.*tostatus-im.contexts.wallet.sheets.*This should make no difference to anything and will not need to be test.
removed the rf event
:wallet/select-send-account-addressas it is unused. - so this won't have any effect here.I also made a minor adjustment to the api of the rf event
wallet/select-send-addressto read a bit easier.This could do with a happy path testing of the send flows for an asset and a token, however the changes are quite small and should be quite "safe"