-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chat spacings #19015
Fix chat spacings #19015
Conversation
Jenkins BuildsClick to see older builds (30)
|
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
12% of end-end tests have passed
Failed tests (41)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
|
Hi @clauxx ! 👋 Please, resolve the conflicts and rebase your PR. |
@mariia-skrypnyk done 👍 |
hey @clauxx all build are failed, could you pls fix and then move to e2e |
81% of end-end tests have passed
Failed tests (8)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Hi @clauxx ! Thanks for rebase. ISSUE 1 "Fix spacing between last message and shell button" has incorrect space: Design: |
@mariia-skrypnyk it looks fine compared to this. We should compare this spacing (last message to shell button) with designs in which there are scrollable messages (left image) and they're scrolled all the way down. On the right we can't really tell what's the spacing cause there's not enough messages to fill the screen. |
75% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Passed tests (6)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Thanks @clauxx . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better 👍
We still have some spacing issues as commented here
@Francesca-G fixed a few other spacing issues as well. Here's an overlap of the implementation over the design (used iPhone 11 Pro cause i didn't find iPhone 13 designs for the chat). |
* fix: chat system messages spacing * fix: spacing between chat actions and time header * fix: distance from last message to shell button * fix: addressed review comment * fix: conflict bug * fix: chat spacings
fixes #19013
Summary
Fix the spacing issues from the chat screen
Areas that maybe impacted
Functional
status: ready