fix: avatar alignment #19073
Merged
fix: avatar alignment #19073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (49)
|
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
2 times, most recently
from
41ab0e8
to
754f6df
Compare
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
from
754f6df
to
3beb4b2
Compare
71% of end-end tests have passedFailed tests (13)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (34)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
2 times, most recently
from
e8061f2
to
38d6481
Compare
94% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
Parveshdhull
approved these changes
Mar 16, 2024
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
2 times, most recently
from
1e6c8e4
to
60d178f
Compare
ajayesivan
reviewed
Mar 20, 2024
| :number-of-lines 1} | ||
| display-name] | ||
| [contact-icon contact theme]] | ||
| [:f> f-username |
There was a problem hiding this comment.
Do we still need :f>?
From ui-guidelines
:f>not needed anymore, all components are functional by default
There was a problem hiding this comment.
no :f> is not needed anymore
ajayesivan
reviewed
Mar 20, 2024
| @@ -133,6 +132,28 @@ | |||
| :profile-picture profile-picture | |||
| :size :big}]])) | |||
|
|
|||
| (defn f-username | |||
There was a problem hiding this comment.
Since all components are functional by default, the f- naming convention doesn't make sense
cc: @flexsurfer
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
from
60d178f
to
aff946e
Compare
92% of end-end tests have passedFailed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
|
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
from
aff946e
to
021060d
Compare
|
Hi @BalogunofAfrica! Thanks for your implementation! Design So will adress it to the design team. |
|
@BalogunofAfrica please tag me when I can retest 🙏 |
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
2 times, most recently
from
fa87a5d
to
c2bc334
Compare
Hi @mariia-skrypnyk You can re test. Android Jank is related to #19387. |
|
Hi @Francesca-G, I have addressed all comments save the dot size. For that, the identicon and dot are generated as one single image, which is what we can animate to scale. We can not animate the dot separately. |
can we create a separate issue to find a solution to this? 🙏 |
|
we already have a similar open issue for indicator size #18257 |
Thanks @mohsen-ghafouri 🙏 cc: @Francesca-G |
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
from
c2bc334
to
879bc1e
Compare
|
@mariia-skrypnyk Can this be merged? |
|
@BalogunofAfrica yes, please! |
BalogunofAfrica
force-pushed
the
bug/avatar-alignment
branch
from
879bc1e
to
25c1325
Compare
mmilad75
pushed a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: balogunofafrica <balogunakanbi.k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18827
Summary
Handles the limit event when creating a new group chat
Platforms
Functional
Steps to test
status: ready