[#19401] Wallet share QR code multiple fixes #19425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
ulisesmac
commented
Mar 27, 2024
ulisesmac
commented
Mar 27, 2024
ulisesmac
commented
Mar 27, 2024
ulisesmac
commented
Mar 27, 2024
J-Son89
approved these changes
Mar 27, 2024
ulisesmac
commented
Mar 27, 2024
ulisesmac
commented
Mar 27, 2024
|
Thanks for the well described/documented pr. 🙏 |
|
HI @ulisesmac just curious, how did you get the case when your address became white? This screen is from the description #19425 (comment) |
pavloburykh
force-pushed
the
19401-share-wallet-scroll-qr-error
branch
from
a6b4567
to
2eca7ec
Compare
98% of end-end tests have passedExpected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
clauxx
approved these changes
Apr 1, 2024
|
Hi @ulisesmac thank you for the fix! Ready for merge and cherrypicking. |
Hi @VolodLytvynenko ! You just need to create a wallet account in desktop and use the Yin Yang theme color |
By adding this prop, `on-layout` can be skipped and the component can be properly rendered faster
- Fix the height of the component being cropped. - Fix the bottom dots not being accurately highlighted. - Fix the blink when the component is mounted
|
Just an fyi we haven't added support for yin-yang yet but we can figure it out in the offsite @ulisesmac - we have most of the solution from before when we discussed it in Porto |
ulisesmac
force-pushed
the
19401-share-wallet-scroll-qr-error
branch
from
2eca7ec
to
1939a23
Compare
cammellos
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Fix key extractions in re-frame/reg-sub * Add `:width` to share-qr-code By adding this prop, `on-layout` can be skipped and the component can be properly rendered faster. * Use `share-qr-code`'s `:width` prop in share profile shell * Fix share qr code for wallet addresses * Fix the height of the component being cropped. * Fix the bottom dots not being accurately highlighted. * Fix the blink when the component is mounted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19401
Summary
The issues reported are:
Exception while scrolling - No longer reproducible ✅
Image cropped in Android - Fixed ✅
Reported vs now:
Additionally, solves some other bugs noticed while checking the code.
The QR no longer blinks:
Before:
Screencast.from.2024-03-27.13-15-39.webm
Now:
Screencast.from.2024-03-27.13-16-50.webm
The bottom indicators (white dots) weren't accurately showing the focused QR:
Before:
Screencast.from.2024-03-27.14-53-05.webm
Now:
Screencast.from.2024-03-27.14-53-45.webm
Other code improvements
Platforms
Steps to test
Open Status
Log in and click on the QR code icon
Change between tabs as showed in the videos.
status: ready