[#302 review]Rework eeprom emulation for buffered access #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2018 15:40
The current EEPROM emulation didn't had any buffered access to the data on the flash. Every access to a byte would trigger a whole page read / write. For writes it would mean, that the whole page would be erased. For backward compability we will keep the current functions as they are, but will add functions to fill/flush the buffer and read from it. The buffer size is static and is one page in size. Fixes: stm32duino#296 Signed-off-by: Nils Hasenbanck <nils.hasenbanck@trendig.com>
Clean up also the old references to the original author/version/date since we already refactored this code quite well. The copyright notice of course is still intact. Signed-off-by: Nils Hasenbanck <nils.hasenbanck@trendig.com>
|
LGTM |
benwaffle
pushed a commit
to benwaffle/Arduino_Core_STM32
that referenced
this pull request
Apr 10, 2019
[stm32duino#302 review]Rework eeprom emulation for buffered access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of #302 from @hasenbanck