Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Virtualization descriptions #1650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Oct 10, 2024

Update Virtualization descriptions based on the docs team review.

Signed-off-by: Shirly Radco sradco@redhat.com

Signed-off-by: Shirly Radco <sradco@redhat.com>
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sradco
Once this PR has been reviewed and has the lgtm label, please assign periklis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

openshift-ci bot commented Oct 10, 2024

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pr-image-mirror-endpoint-monitoring-operator 7b61118 link true /test pr-image-mirror-endpoint-monitoring-operator
ci/prow/test-e2e 7b61118 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -501,7 +501,7 @@ data:
},
{
"datasource": null,
"description": "Total number of clusters that have alerts that are firing with the operator_health_impact level: warning.",
"description": "Total number of clusters with warning level issues that impact on the operator health, based on firing alerts and operator conditions. This means they are at risk of loosing some core functionality soon.",
Copy link
Contributor

@dockerymick dockerymick Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a different word for firing?

Suggested change
"description": "Total number of clusters with warning level issues that impact on the operator health, based on firing alerts and operator conditions. This means they are at risk of loosing some core functionality soon.",
"description": "Total number of clusters with warning level issues that impact the operator health, due to alerts and operator conditions. This means there is a risk of core functionality loss for your clusters.",

@@ -100,7 +100,7 @@ data:
},
{
"datasource": null,
"description": "Total number of clusters that have alerts that are firing with the operator_health_impact level: critical.",
"description": "Total number of clusters with critical issues that impact on the operator health, based on firing alerts and operator conditions. This means they lost some core functionality.",
Copy link
Contributor

@dockerymick dockerymick Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something different than firing?

Suggested change
"description": "Total number of clusters with critical issues that impact on the operator health, based on firing alerts and operator conditions. This means they lost some core functionality.",
"description": "Total number of clusters with critical issues that impact the operator health, due to alerts and operator conditions. This means they lost some core functionality.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants