-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Virtualization descriptions #1650
base: main
Are you sure you want to change the base?
Update Virtualization descriptions #1650
Conversation
Signed-off-by: Shirly Radco <sradco@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sradco The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
@sradco: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -501,7 +501,7 @@ data: | |||
}, | |||
{ | |||
"datasource": null, | |||
"description": "Total number of clusters that have alerts that are firing with the operator_health_impact level: warning.", | |||
"description": "Total number of clusters with warning level issues that impact on the operator health, based on firing alerts and operator conditions. This means they are at risk of loosing some core functionality soon.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use a different word for firing?
"description": "Total number of clusters with warning level issues that impact on the operator health, based on firing alerts and operator conditions. This means they are at risk of loosing some core functionality soon.", | |
"description": "Total number of clusters with warning level issues that impact the operator health, due to alerts and operator conditions. This means there is a risk of core functionality loss for your clusters.", |
@@ -100,7 +100,7 @@ data: | |||
}, | |||
{ | |||
"datasource": null, | |||
"description": "Total number of clusters that have alerts that are firing with the operator_health_impact level: critical.", | |||
"description": "Total number of clusters with critical issues that impact on the operator health, based on firing alerts and operator conditions. This means they lost some core functionality.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use something different than firing?
"description": "Total number of clusters with critical issues that impact on the operator health, based on firing alerts and operator conditions. This means they lost some core functionality.", | |
"description": "Total number of clusters with critical issues that impact the operator health, due to alerts and operator conditions. This means they lost some core functionality.", |
Update Virtualization descriptions based on the docs team review.
Signed-off-by: Shirly Radco sradco@redhat.com