This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make selectors Storybook 8 compatible #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
cdedreuille and
valentinpalkovic
as code owners
|
@cdedreuille FYI this is not the most ideal solution but it's what will get us unblocked. Feel free to propose another solution when there is availability! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes storybookjs/storybook#25288
This PR makes it so that the selectors used for the "interactive playground" step are compatible with both SB 7 and 8. Because react joyride can't highlight two elements as if they're one, there will be visual differences in Storybook 8, given that what used to be a single element now is a combination of two.
Storybook 7
Storybook 8
