Merge pull request #25415 from storybookjs/yann/remove-static-dir-flag

Core: Remove unused staticDir type
storybookjs · Jan 4, 2024 · 470d2c8 · 470d2c8
2 parents 32ec844 + 5e7c185
commit 470d2c8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/code/lib/core-events/src/errors/server-errors.ts b/code/lib/core-events/src/errors/server-errors.ts
@@ -120,6 +120,8 @@ export class CouldNotEvaluateFrameworkError extends StorybookError {
   }
 }
 
+// this error is not used anymore, but we keep it to maintain unique its error code
+// which is used for telemetry
 export class ConflictingStaticDirConfigError extends StorybookError {
   readonly category = Category.CORE_SERVER;
 
@@ -138,7 +140,6 @@ export class ConflictingStaticDirConfigError extends StorybookError {
     `;
   }
 }
-
 export class InvalidStoriesEntryError extends StorybookError {
   readonly category = Category.CORE_COMMON;
 

diff --git a/code/lib/core-server/src/presets/common-preset.ts b/code/lib/core-server/src/presets/common-preset.ts
@@ -46,7 +46,7 @@ export const staticDirs: PresetPropertyFn<'staticDirs'> = async (values = []) =>
 
 export const favicon = async (
   value: string | undefined,
-  options: Pick<Options, 'presets' | 'configDir' | 'staticDir'>
+  options: Pick<Options, 'presets' | 'configDir'>
 ) => {
   if (value) {
     return value;

diff --git a/code/lib/core-server/src/utils/server-statics.ts b/code/lib/core-server/src/utils/server-statics.ts
@@ -69,7 +69,7 @@ export const parseStaticDir = async (arg: string) => {
     throw new Error(
       dedent(chalk`
         Failed to load static files, no such directory: {cyan ${staticPath}}
-        Make sure this directory exists, or omit the {bold -s (--static-dir)} option.
+        Make sure this directory exists.
       `)
     );
   }

diff --git a/code/lib/types/src/modules/core-common.ts b/code/lib/types/src/modules/core-common.ts
@@ -172,10 +172,6 @@ export interface CLIOptions {
   host?: string;
   initialPath?: string;
   exactPort?: boolean;
-  /**
-   * @deprecated Use 'staticDirs' Storybook Configuration option instead
-   */
-  staticDir?: string[];
   configDir?: string;
   https?: boolean;
   sslCa?: string[];