Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Migrate @storybook/addon-backgrounds to strict-ts #22178

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Build: Migrate @storybook/addon-backgrounds to strict-ts #22178

merged 5 commits into from
Sep 19, 2023

Conversation

kasperpeulen
Copy link
Contributor

Issuse #22176

What I did

Migrate @storybook/addon-backgrounds to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen self-assigned this Apr 20, 2023
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Apr 20, 2023
@kasperpeulen kasperpeulen mentioned this pull request Apr 20, 2023
Closed
Base automatically changed from kasper/strict-ts to next April 25, 2023 07:45
@kasperpeulen kasperpeulen removed their assignment May 1, 2023
@JReinhold JReinhold self-assigned this May 1, 2023
@JReinhold JReinhold self-requested a review May 1, 2023 14:18
@kasperpeulen
Copy link
Contributor Author

@yannbf @JReinhold I'm going on holiday Tuesday and could use a hand. Would one of you be able to review this before I leave? I'd really appreciate it, thanks!

@yannbf yannbf added ci:normal maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Sep 19, 2023
@ndelangen ndelangen self-assigned this Sep 19, 2023
@ndelangen ndelangen merged commit aae03b0 into next Sep 19, 2023
60 of 65 checks passed
@ndelangen ndelangen deleted the kasper/strict-ts-backgrounds branch September 19, 2023 11:14
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees

@ndelangen ndelangen

@JReinhold JReinhold

Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kasperpeulen @ndelangen @yannbf @JReinhold