Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate @storybook/theming to strict TS #22376

Merged
merged 7 commits into from
May 4, 2023
Merged

Migrate @storybook/theming to strict TS #22376

merged 7 commits into from
May 4, 2023

Conversation

kuriacka
Copy link
Contributor

@kuriacka kuriacka commented May 3, 2023

Issue #22176

What I did

Migrate @storybook/theming to strict-ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 3, 2023
@kasperpeulen kasperpeulen self-requested a review May 3, 2023 14:39
kasperpeulen
kasperpeulen approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job :) LGTM!

@kasperpeulen kasperpeulen merged commit b3ecfe1 into storybookjs:next May 4, 2023
@kasperpeulen kasperpeulen mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuriacka @kasperpeulen