Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Count onboarding stories #23092

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 15, 2023

N/A

What I did

Add onboarding story count per #22558

How to test

See attached tests, or run a sandbox with STORYBOOK_TELEMETRY_DEBUG=1 and add a Warning story to the Button.

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Jun 15, 2023
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 15, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 9f151fc into next Jun 15, 2023
@shilman shilman deleted the shilman/count-onboarding-stories branch June 15, 2023 17:42
JReinhold pushed a commit that referenced this pull request Jun 15, 2023
…tories

Telemetry: Count onboarding stories
(cherry picked from commit 9f151fc)
JReinhold pushed a commit that referenced this pull request Jun 15, 2023
…tories

Telemetry: Count onboarding stories
(cherry picked from commit 9f151fc)
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
9 tasks
JReinhold pushed a commit that referenced this pull request Jun 16, 2023
…tories

Telemetry: Count onboarding stories
(cherry picked from commit 9f151fc)
JReinhold pushed a commit that referenced this pull request Jun 17, 2023
…tories

Telemetry: Count onboarding stories
(cherry picked from commit 9f151fc)
This was referenced Jun 17, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants