Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack: Fix channel format for loading status #23139

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 19, 2023

Closes #23090

What I did

After using a Channel class to contruct the serverChannel, it now handled the wrapping and unwrapping of values between emit and subscribers.
The old code sending data from server wasn't changed and was wrapping the value needed to be sent over the channel in an array itself.

This caused the data to array in an unexpected format in the client, locking it into a ever-loading state,

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --template cra/default-ts
  2. Open Storybook in your browser

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 19, 2023
@ndelangen ndelangen merged commit 63e9c52 into next Jun 19, 2023
@ndelangen ndelangen deleted the norbert/fix-23090 branch June 19, 2023 19:59
@shilman shilman removed the server label Jun 20, 2023
@shilman shilman changed the title Server: Do not wrap data on channel in an array Core: Do not wrap data on channel in an array Jun 20, 2023
@shilman shilman changed the title Core: Do not wrap data on channel in an array Webpack: Do not wrap data on channel in an array Jun 20, 2023
@shilman shilman changed the title Webpack: Do not wrap data on channel in an array Webpack: Fix channel format for loading status Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Webpack Hot Module Replacement doesn't work
3 participants