UI: Keep mobile drawer open on component selection #24258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdedreuille
requested review from
valentinpalkovic,
ndelangen,
JReinhold,
tmeasday,
kasperpeulen,
kylegach and
jonniebigodes
as code owners
JReinhold
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Code wise this looks good, I'll test the functionality tomorrow.
We want tests for this, either stories or e2e - we can work together on this. I see in the PR description you've checked off all the tests, but that's not quite right though, so maybe you've misunderstood that part?
I also think it's time to move isDesktop to the Mobile provider, so we don't keep creating change listeners all over the place. Feel free to do that here or in a follow up PR
|
@JReinhold I made the change on the layout provider to include |
JReinhold
reviewed
Sep 22, 2023
JReinhold
reviewed
Sep 22, 2023
Close icon mobile
JReinhold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24255
Closes #24256
What I did
On the new mobile navigation we debated on the best way to close the main navigation when selected a story. We decided that the drawer will only close if a story is selected, not when a component is toggled. The behaviour remain unchanged on desktop.
I also improved a few styles on the sidebar as well as the about section on mobile
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>