Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix missing favicon during dev #24356

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

ndelangen
Copy link
Member

Closes #21245

What I did

I removed the dependency on serve-favicon.
It doesn't support .svg-favicons.

I added a custom route in the useStatics function instead.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  • I manually ran the UI storybook
  • I opened the storybook in my browser and navigated to localhost:6006/favicon.svg

The SVG showed up as expected.

I also opened the UI storybook in a custom port (to break the hard browser cache of favicons, and saw it load the svg favicon fine in my browser

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Oct 3, 2023
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core ci:normal labels Oct 3, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/serve-favicon@2.5.5

@ndelangen ndelangen merged commit f23fa9c into next Oct 3, 2023
57 of 59 checks passed
@ndelangen ndelangen deleted the norbert/fix-missing-favicon-during-dev branch October 3, 2023 12:41
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
20 tasks
storybook-bot pushed a commit that referenced this pull request Oct 3, 2023
…n-during-dev

Core: Fix missing favicon during dev
(cherry picked from commit f23fa9c)
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
4 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FavIcon doesn't load on localhost with Vite builder
2 participants