Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Make warnOnIncompatibleAddons fault-tolerant #24880

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Core: Make warnOnIncompatibleAddons fault-tolerant #24880

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d0a1da
Core: do not fail the build on warnOnIncompatibleAddons
taozhou-glean Nov 16, 2023
b385449
fix lint
taozhou-glean Nov 17, 2023
defbd62
Update code/lib/core-server/src/build-dev.ts
yannbf Nov 20, 2023
661cb43
Merge branch 'next' into tao-warnOnIncompatibleAddons
taozhou-glean Nov 20, 2023
31478ef
Merge branch 'next' into tao-warnOnIncompatibleAddons
yannbf Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion code/lib/core-server/src/build-dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@ export async function buildDevStandalone(

corePresets.push(join(frameworkName, 'preset'));

await warnOnIncompatibleAddons(config);
try {
await warnOnIncompatibleAddons(config);
} catch (e) {
console.warn('Failed to check for incompatible addons', e);
yannbf marked this conversation as resolved.
Show resolved Hide resolved
}

// Load first pass: We need to determine the builder
// We need to do this because builders might introduce 'overridePresets' which we need to take into account
Expand Down
Loading