Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix types in custom stories implementation snippet #25300

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kylegach
Copy link
Contributor

Closes #23624

What I did

Added type annotations to code snippet

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

N/A; docs-only change

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kylegach kylegach added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels Dec 21, 2023
@kylegach kylegach self-assigned this Dec 21, 2023
@kylegach kylegach merged commit 7ecf05e into next Jan 25, 2024
18 checks passed
@kylegach kylegach deleted the fix-type-custom-stories branch January 25, 2024 20:25
storybook-bot pushed a commit that referenced this pull request Jan 25, 2024
Docs: Fix types in custom stories implementation snippet
(cherry picked from commit 7ecf05e)
storybook-bot pushed a commit that referenced this pull request Jan 25, 2024
Docs: Fix types in custom stories implementation snippet
(cherry picked from commit 7ecf05e)
storybook-bot pushed a commit that referenced this pull request Jan 25, 2024
Docs: Fix types in custom stories implementation snippet
(cherry picked from commit 7ecf05e)
storybook-bot pushed a commit that referenced this pull request Jan 26, 2024
Docs: Fix types in custom stories implementation snippet
(cherry picked from commit 7ecf05e)
storybook-bot pushed a commit that referenced this pull request Jan 30, 2024
Docs: Fix types in custom stories implementation snippet
(cherry picked from commit 7ecf05e)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: React StorybookConfig type definition inconsistent with docs
1 participant