Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Make sure loaders/decorators can be used as array #26514

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 15, 2024

What I did

Make sure loaders/decorators can be used as array.

Our type definitions allow both an array as a function to be assigned to loaders or decorators. This worked in 7.6 but regressed in 8.0.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Mar 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 58120f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen marked this pull request as ready for review March 15, 2024 13:19
@valentinpalkovic
Copy link
Contributor

Can you provide some background on this fix? There isn't an issue linked, and I don't understand the motivation.

@kasperpeulen
Copy link
Contributor Author

@valentinpalkovic Our type definitions allow both an array as a function to be assigned to loaders or decorators. This worked in 7.6 but regressed in 8.0. So I fixed it and added a unit test :)

@valentinpalkovic
Copy link
Contributor

I see. Thanks for the clarification!

@kasperpeulen kasperpeulen merged commit b016a4f into next Mar 18, 2024
63 of 68 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-single-loaders-decorators branch March 18, 2024 09:37
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
15 tasks
@shilman shilman changed the title Bug: Make sure loaders/decorators can be used as array Types: Make sure loaders/decorators can be used as array Mar 18, 2024
@shilman shilman changed the title Types: Make sure loaders/decorators can be used as array CSF: Make sure loaders/decorators can be used as array Mar 18, 2024
@shilman shilman added csf and removed typescript labels Mar 18, 2024
@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 19, 2024
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…decorators

Bug: Make sure loaders/decorators can be used as array
(cherry picked from commit b016a4f)
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
11 tasks
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…decorators

Bug: Make sure loaders/decorators can be used as array
(cherry picked from commit b016a4f)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal csf patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants