Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Migrate from read-pkg-up to fd-package-json #28272

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jun 18, 2024

Migrates away from using read-pkg-up to a lighter alternative with fewer deep dependencies.

Note that this approach results in us no longer normalising the JSON before dealing with it. That should be fine, though, as the normalisation isn't type checking, it is simply normalising some specific fields (not all of them) which we don't touch.

e.g. you could pass the old one nonsense like {scripts: []} and it would leave it as is

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

N/A (unit tests should cover)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Migrates away from using read-pkg-up to a lighter alternative with fewer
deep dependencies.
Copy link

nx-cloud bot commented Jun 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af081d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title feat: migrate from read-pkg-up Deps: Migrate from read-pkg-up to fd-package-json Jun 23, 2024
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@shilman shilman merged commit 1266a65 into storybookjs:next Jun 23, 2024
55 of 58 checks passed
@43081j 43081j deleted the pkgdown branch June 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants