Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Update outputPath default value in angular-cli-webpack.js #28418

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 2, 2024

Closes N/A

What I did

#28144 introduced a regression which sets the outputPath to undefined instead of noop-out if it isn't defined.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28418-sha-1934512b. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28418-sha-1934512b sandbox or in an existing project with npx storybook@0.0.0-pr-28418-sha-1934512b upgrade.

More information
Published version 0.0.0-pr-28418-sha-1934512b
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/fix-angular-output-path-empty
Commit 1934512b
Datetime Tue Jul 2 09:01:34 UTC 2024 (1719910894)
Workflow run 9758038047

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28418

Copy link

nx-cloud bot commented Jul 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1934512. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit 9781303 into next Jul 2, 2024
66 of 67 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-angular-output-path-empty branch July 2, 2024 09:39
@valentinpalkovic valentinpalkovic added needs qa Indicates that this needs manual QA during the upcoming minor/major release and removed needs qa Indicates that this needs manual QA during the upcoming minor/major release labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant