Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Prerelease 8.3.0-alpha.2 #28617

Merged
merged 31 commits into from
Jul 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 16, 2024

This is an automated pull request that bumps the version from 8.3.0-alpha.1 to 8.3.0-alpha.2.
Once this pull request is merged, it will trigger a new release of version 8.3.0-alpha.2.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: CPC: Correct path to the @storybook/theming/create alias #28643 (will also be patched)
  • 🐛 Bug: Onboarding: Fix code snippet when story name differs from export name #28649
  • 🐛 Bug: CPC: Add the globals export for manager #28650 (will also be patched)
  • 🐛 Bug: Vue: Fix out of memory error when using vue-component-meta #28589
  • 🐛 Bug: Fix: Add header for MountMustBeDestructuredError message #28590 (will also be patched)
  • 🐛 Bug: Build: Remove external overrides, use package.json as source of truth #28632
  • 🐛 Bug: Fix: Prevent iframe from capturing mouse events in composed Storybooks #28568
  • 🐛 Bug: Addon-Interactions: Fix status in panel tab #28580
  • 🔧 Maintenance: CLI: Add conditional logging for manager and preview start #28603
  • 🔧 Maintenance: Core: Fix manager-builder tsconfig to emit react-jsx #28541

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.3.0-alpha.2

  • Addon-Interactions: Fix status in panel tab - #28580, thanks @yannbf!
  • Build: Remove external overrides, use package.json as source of truth - #28632, thanks @kasperpeulen!
  • CLI: Add conditional logging for manager and preview start - #28603, thanks @tobiasdiez!
  • CPC: Add the globals export for manager - #28650, thanks @ndelangen!
  • CPC: Correct path to the @storybook/theming/create alias - #28643, thanks @Averethel!
  • Core: Fix manager-builder tsconfig to emit react-jsx - #28541, thanks @williamhelmrath!
  • Fix: Add header for MountMustBeDestructuredError message - #28590, thanks @0916dhkim!
  • Fix: Prevent iframe from capturing mouse events in composed Storybooks - #28568, thanks @Vincentdevreede!
  • Onboarding: Fix code snippet when story name differs from export name - #28649, thanks @ghengeveld!
  • Vue: Fix out of memory error when using vue-component-meta - #28589, thanks @larsrickert!

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Jul 16, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated code/core/assets/server/addon.tsconfig.json to use react-jsx for JSX transform.
  • Added deferredNextVersion field in code/package.json with value 8.3.0-alpha.2.
  • Updated docs/versions/next.json to reflect version 8.3.0-alpha.2 and changelog.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

CLI: Add conditional logging for manager and preview start
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from f43fd42 to 8450bc8 Compare July 16, 2024 10:34
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from 8450bc8 to 71418d9 Compare July 16, 2024 11:41
Fix: Prevent iframe from capturing mouse events in composed Storybooks
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from 71418d9 to ce7641e Compare July 16, 2024 12:01
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from ce7641e to 5e29643 Compare July 17, 2024 13:26
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from 5e29643 to 0c786f6 Compare July 18, 2024 21:39
@MathiasCiarlo
Copy link

@kylegach @jonniebigodes this will make our static bundle go frow 84 to 4 MB (Out of memory error), greatly reducing build time 🥳 Hope you get the time to merge it soon 🙏

Averethel and others added 3 commits July 19, 2024 10:41
The path to the `@storybook/theming/create` included `package.json` which made it impossible to resolve the alias.

```
 '@storybook/theming/create': '<localPath>/node_modules/storybook/package.json/core/theming/create.js',
```

 '@storybook/theming/create': '<localPath>/node_modules/storybook/core/theming/create.js',
Onboarding: Fix code snippet when story name differs from export name
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from 0c786f6 to 44ad63d Compare July 19, 2024 10:42
ndelangen and others added 2 commits July 19, 2024 13:16
@storybook-bot storybook-bot force-pushed the version-non-patch-from-8.3.0-alpha.1 branch from 44ad63d to a495441 Compare July 19, 2024 11:19
@vanessayuenn vanessayuenn added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Jul 19, 2024
Copy link

nx-cloud bot commented Jul 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a495441. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@vanessayuenn vanessayuenn merged commit 7844aa5 into next-release Jul 19, 2024
103 of 106 checks passed
@vanessayuenn vanessayuenn deleted the version-non-patch-from-8.3.0-alpha.1 branch July 19, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.