Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade and streamline Playwright dependencies #28710

Merged
merged 14 commits into from
Aug 14, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 25, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 102 B 1.52 0%
initSize 167 MB 167 MB 102 B 1.4 0%
diffSize 91.1 MB 91.1 MB 0 B 0.18 0%
buildSize 7.42 MB 7.42 MB 0 B 0.5 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -0.5 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B 0.5 0%
buildSbPreviewSize 351 kB 351 kB 0 B -0.5 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B 0.5 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -0.5 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.7s 8.9s 2.1s -0.9 24.5%
generateTime 18.3s 22.6s 4.3s 1.01 19%
initTime 16.5s 20.7s 4.1s 1.67 🔺20.3%
buildTime 12.3s 15.8s 3.5s 3.37 🔺22.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 9.3s 7.4s -1s -927ms -1 -26%
devManagerResponsive 5.1s 4.8s -214ms -0.47 -4.4%
devManagerHeaderVisible 847ms 893ms 46ms 0.54 5.2%
devManagerIndexVisible 893ms 935ms 42ms 0.63 4.5%
devStoryVisibleUncached 1.5s 1.3s -219ms 0.13 -16.1%
devStoryVisible 917ms 936ms 19ms 0.46 2%
devAutodocsVisible 895ms 733ms -162ms -0.34 -22.1%
devMDXVisible 843ms 707ms -136ms -0.56 -19.2%
buildManagerHeaderVisible 743ms 819ms 76ms 0.54 9.3%
buildManagerIndexVisible 749ms 821ms 72ms 0.51 8.8%
buildStoryVisible 793ms 916ms 123ms 1.04 13.4%
buildAutodocsVisible 720ms 729ms 9ms 0.19 1.2%
buildMDXVisible 700ms 712ms 12ms 0.36 1.7%

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Jul 25, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Upgraded Playwright dependencies and streamlined configurations to enhance compatibility and efficiency.

  • Updated .circleci/config.yml to use Playwright Docker image v1.45.1-jammy and consolidated executors.
  • Upgraded Playwright dependencies in code/package.json and scripts/package.json from 1.36.0 to 1.45.1.
  • Updated Playwright dependencies in test-storybooks/portable-stories-kitchen-sink/react/package.json, svelte/package.json, and vue3/package.json to 1.45.1.
  • Changed @storybook/csf version in code/package.json to a fixed version 0.1.11.

Ensure thorough testing to verify compatibility and stability.

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 61416c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the yann/upgrade-and-streamline-pw branch from 6fefd83 to 19fc755 Compare July 25, 2024 16:34
@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Jul 25, 2024
@yannbf yannbf force-pushed the yann/upgrade-and-streamline-pw branch from e20dbaa to 92686fb Compare July 25, 2024 17:14
@ndelangen ndelangen assigned ndelangen and unassigned yannbf Aug 13, 2024
@yannbf
Copy link
Member Author

yannbf commented Aug 13, 2024

@ndelangen we should update to PW 1.46, just got released!

@yannbf yannbf force-pushed the yann/upgrade-and-streamline-pw branch from d2fee99 to 58019ef Compare August 13, 2024 09:26
@ndelangen ndelangen merged commit 70e24c0 into next Aug 14, 2024
106 checks passed
@ndelangen ndelangen deleted the yann/upgrade-and-streamline-pw branch August 14, 2024 07:12
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants