-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Disable save-from-controls logs for example stories #28870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c64542e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
31e8701
to
c64542e
Compare
Closes N/A
What I did
Save-from-controls telemetry from example stories are distorting usage metrics. Let's not record them at all.
Checklist for Contributors
Manual testing
In a sandbox:
title
) and edit a story with SfC and verify that telemetry is sentDocumentation
MIGRATION.MD
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This pull request introduces a change to prevent telemetry data collection for CLI example stories in Storybook's save-story functionality.
IS_CLI_EXAMPLE
regex incode/core/src/core-server/utils/save-story/save-story.ts
to identify CLI example storiesinitializeSaveStory
function to skip data collection for CLI example stories