CLI: Install Svelte CSF v5 in Svelte5 projects #29323
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| const packageManager = { | ||
| getInstalledVersion: async (pkg: string) => pkg === 'svelte' ? svelteVersion : undefined, | ||
| getAllDependencies: async () => ({ svelte: `^${svelteVersion}` }) | ||
| } as any as JsPackageManager; |
There was a problem hiding this comment.
style: Avoid using 'as any' type assertion. Consider creating a mock class that implements JsPackageManager interface
| const packageManager = { | ||
| getInstalledVersion: async (pkg: string) => undefined, | ||
| getAllDependencies: async () => ({ svelte: svelteSpecifier }) | ||
| } as any as JsPackageManager; |
There was a problem hiding this comment.
style: Same as above, avoid 'as any' type assertion
| try { | ||
| const coerced = coerce(svelteSpecifier); | ||
| if(coerced?.version) { | ||
| return versionHelper(major(coerced.version)); | ||
| } | ||
| } catch {} |
There was a problem hiding this comment.
style: Consider handling specific errors instead of using an empty catch block
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c5e384e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
JReinhold
added
ci:daily
Yes we do. I can provide the stories, if you can figure out how to correctly select them based on the version? |
|
Let's do that as a separate task. And after Svelte5 is released? Self-merging @JReinhold |
Closes N/A
What I did
Prepare
storybook initfor the Svelte 5 release, in both Svelte and SvelteKit projects:package.jsonversion specifieraddon-svelte-csf@JReinhold Do we need to update the template stories for Svelte CSF v5?
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
What I did:
svelte-kit/skeleton-tssandbox and verify that it's using the latest v4 stable release ofaddon-svelte-csfsvelte-kit/prerelease-tssandbox and verify that it's using the latest prerelease ofaddon-svelte-csf🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR updates the Storybook CLI to dynamically install the appropriate version of addon-svelte-csf based on the installed Svelte version, preparing for Svelte 5 compatibility.
getAddonSvelteCsfVersionfunction incode/lib/create-storybook/src/generators/SVELTE/index.tsto determine correct addon versioncode/lib/create-storybook/src/generators/SVELTE/index.test.tsfor various Svelte versionscode/lib/create-storybook/src/generators/SVELTEKIT/index.tsto use dynamic addon version