Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a new object of the same type instead of forcing MockSet #155

Merged
merged 2 commits into from
Feb 27, 2022

Conversation

lvieirajr
Copy link
Collaborator

This PR will make it so that classes that inherit from MockSet will work when chaining multiple methods.
Solves #150

@lvieirajr lvieirajr self-assigned this Feb 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #155 (2257f32) into master (49d7ca3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files           7        7           
  Lines         927      929    +2     
=======================================
+ Hits          920      922    +2     
  Misses          7        7           
Impacted Files Coverage Δ
django_mock_queries/query.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d7ca3...2257f32. Read the comment docs.

@stphivos
Copy link
Owner

Awesome thanks!!

@stphivos stphivos merged commit 39b7331 into stphivos:master Feb 27, 2022
@rbusquet
Copy link
Contributor

@stphivos can we get the changes in this PR on a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants