-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare time.Time objects for equality correctly #979
Compare time.Time objects for equality correctly #979
Conversation
@leoleoasd , did you talk about it? |
9a4e54b
to
0433460
Compare
@leoleoasd check please last update |
LGTM, but I don't have write access to this repo, we need to wait for a reviewer with write access 😂 |
I know) |
@boyan-soubachov could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you :)
@leoleoasd merged)) Thank you |
It looks like this was reverted in ed4976c? |
Adding test
Summary
Fix assert.ObjectsAreEqual bug with not equals time.Time before and after serializing\deserializing
Changes
Added a check in ObectsAreEqual in case the arguments are a time object
Motivation
Fix bug to use test in docker
Related issues
Closes #950
Fix #951