Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of unit tests to use KRaft - part 6 #10436

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 11, 2024

Type of change

  • Task

Description

Part 6 of the unit test refactoring to use KRaft:

  • KafkaAssemblyOperatorCustomCertMockTest is not dependent on ZooKeeper in any way and was just updated to use KRaft
  • KafkaAssemblyOperatorNodePoolWatcherTest is not dependent on ZooKeeper in any way and was just updated to use KRaft
  • KafkaAssemblyOperatorManualRollingUpdatesTest used ZooKeeper. The original class was kept in a copy as KafkaAssemblyOperatorManualRollingUpdatesZooBasedTest and the KafkaAssemblyOperatorManualRollingUpdatesTest class itself was updated to use KRaft
  • KafkaAssemblyOperatorNonParametrizedTest used ZooKeeper in some tests. The original class KafkaAssemblyOperatorNonParametrizedTest has been used to keep the tests that did not need ZooKeeper based clusters. A new class KafkaAssemblyOperatorNonParametrizedZooBasedTest was created to hols the ZooKeeper related tests (this class will be removed when ZooKeeper support is removed).

Checklist

  • Write tests
  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.43.0 milestone Aug 11, 2024
@scholzj scholzj requested a review from ppatierno August 11, 2024 12:34
@scholzj scholzj merged commit 7a1db8a into strimzi:main Aug 12, 2024
13 checks passed
@scholzj scholzj deleted the wave-6-of-KRaft-unit-test-updates branch August 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants