Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple API changes #1053

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Multiple API changes #1053

merged 1 commit into from
Oct 26, 2020

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Oct 26, 2020

Multiple API changes:

  • Improving Typescript types for nullable parameters and introduced Stripe.Emptyable as a type
  • Add support for payment_method_options[card][cvc_token] on PaymentIntent
  • Add support for cvc_update[cvc] on Token creation

Codegen for openapi e215279

r? @richardm-stripe
cc @stripe/api-libraries

* A single-use `cvc_update` Token that represents a card CVC value. When provided, the CVC value will be verified during the card payment attempt. This parameter can only be provided during confirmation.
*/
cvc_token?: string;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what's really new

@@ -205,12 +205,12 @@ declare module 'stripe' {
/**
* Inventory type. Possible values are `finite`, `bucket` (not quantified), and `infinite`.
*/
type?: Inventory.Type;
type: Inventory.Type;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new as it's now required in the types (the API always required it but it didn't reflect properly)

/**
* The updated CVC value this token will represent.
*/
cvc_update?: TokenCreateParams.CvcUpdate;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new

* The CVC value, in string form.
*/
cvc: string;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new

@remi-stripe remi-stripe changed the title [WIP] Multiple API changes Multiple API changes Oct 26, 2020
@remi-stripe remi-stripe merged commit 370c546 into master Oct 26, 2020
@remi-stripe remi-stripe deleted the remi/codegen-e215279 branch October 26, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants