Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow confirmPayment to be called without payment method #1084

Merged

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

allows merchants to confirm a payment intent that has had the payment method attached on the server side

Motivation

closes #614

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe changed the title allow confirmPayment to be called without payment method feat: allow confirmPayment to be called without payment method Aug 10, 2022
@charliecruzan-stripe charliecruzan-stripe merged commit 72769a5 into master Aug 15, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/confirm-payment-without-method branch August 15, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confirmPayment should work with an empty data (no payment method provided at that step)
1 participant