Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expo config plugin version #1111

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

closes #1108

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 28911e3 into master Sep 2, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/expo-config-plugin branch September 2, 2022 08:53
@RdC1965
Copy link

RdC1965 commented Oct 17, 2022

I've seen that this fix solves the problem. However, it was added in version 0.19.0, and whenever I install it (expo SDK 46.0.16) I subsequently receive the following message:

Some dependencies are incompatible with the installed expo package version:

  • @stripe/stripe-react-native - expected version: 0.13.1 - actual version installed: 0.19.0

@Olli2
Copy link

Olli2 commented Oct 24, 2022

+1 Same problem here

@kmehner
Copy link

kmehner commented Oct 28, 2022

+1 Same problem here

If I run expo doctor in an expo 46 project it says:
Expected package @expo/config-plugins@^5.0.0
Found invalid:
@expo/config-plugins@4.1.5

I ran the upgrade and then I get:
@stripe/stripe-react-native - expected version: 0.13.1 - actual version installed: 0.19.0

It appears that 0.19.0 is the correct version for SDK 46 but cannot find a way to avoid the error.

@GSolari79
Copy link

Do we have any news? I cannot develop with expo SDK46 and cannot have the @expo/config-plugins@^5.0.0 dependency that is required by this SDK.

@charliecruzan-stripe
Copy link
Collaborator Author

To get this fix, you'll need to use v0.19.0, which means you will need to upgrade your expo SDK to 47 (46 still uses 0.13.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump @expo/config-plugins for expo 46 support
5 participants