Sets return URL for connections based on urlScheme #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vardges-stripe
requested review from
acomley-stripe and
charliecruzan-stripe
as code owners
charliecruzan-stripe
approved these changes
Oct 19, 2022
|
@charliecruzan-stripe good catch, added here https://git.corp.stripe.com/stripe-internal/pay-server/pull/533986 |
vardges-stripe
force-pushed
the
vardges/add_return_url
branch
from
e83c513
to
45a0099
Compare
|
@charliecruzan-stripe had to bump iOS pod version. |
|
@charliecruzan-stripe any idea why the e2e tests are failing? |
|
those e2e failures are unrelated, we've been having some flakiness in the tests on Github Actions, but running locally they pass just fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Constructs and sets a financial connections return url based on provided urlScheme
Motivation
App2app authentication support.
Testing
Documentation
Select one: