Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for existence of pass on paired watch #1219

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

canAddCardToWallet now check specifically for the existence of passes that exist on paired device like apple watches if the hasPairedAppleWatch bool is true. If a pass exists on only one of the device and its paired device, then the merchant should show the 'add to apple wallet' button. added new statuses to the enum for debugging/clarity.

Motivation

Apple's guidelines around this have changed.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • [] This PR does not result in any developer-facing changes.

overrides #1162

@charliecruzan-stripe charliecruzan-stripe force-pushed the charliecruzan/updatepushprovisioningforapplewatch-2 branch from 84e29f3 to afe48d0 Compare December 2, 2022 00:10
@charliecruzan-stripe charliecruzan-stripe merged commit de9727e into master Dec 2, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/updatepushprovisioningforapplewatch-2 branch December 2, 2022 14:43
@grantmac
Copy link

grantmac commented Oct 4, 2023

Hi @charliecruzan-stripe
Some questions if that's ok:

  • What happens if this is set to true, and the device doesn't have a paired watch?
  • Does this handle the use case where the pass exists on the iPhone but not the paired watch?

Thanks

@charliecruzan-stripe
Copy link
Collaborator Author

What happens if this is set to true, and the device doesn't have a paired watch?

The SDK would check the paired devices for the payment pass, and wouldn't find any

Does this handle the use case where the pass exists on the iPhone but not the paired watch?

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants