Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve with better errors on iOS #1399

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: Resolve with better errors on iOS #1399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ios/StripeSdk.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,8 @@ class StripeSdk: RCTEventEmitter, STPBankSelectionViewControllerDelegate, UIAdap
case .canceled:
resolve(Errors.createError(ErrorType.Canceled, "The payment flow has been canceled"))
case .failed(let error):
resolve(Errors.createError(ErrorType.Failed, error.localizedDescription))
resolve(Errors.createError(ErrorType.Failed, error))
}

}
} else {
resolve(Errors.createError(ErrorType.Failed, "No payment sheet has been initialized yet"))
Expand Down Expand Up @@ -221,7 +220,7 @@ class StripeSdk: RCTEventEmitter, STPBankSelectionViewControllerDelegate, UIAdap

STPAPIClient.shared.createToken(forCVCUpdate: cvc) { (token, error) in
if error != nil || token == nil {
resolve(Errors.createError(ErrorType.Failed, error?.localizedDescription ?? ""))
resolve(Errors.createError(ErrorType.Failed, error as? NSError))
} else {
let tokenId = token?.tokenId
resolve(["tokenId": tokenId])
Expand Down Expand Up @@ -558,7 +557,7 @@ class StripeSdk: RCTEventEmitter, STPBankSelectionViewControllerDelegate, UIAdap
if let paymentMethodParams = paymentMethodParams {
STPAPIClient.shared.createPaymentMethod(with: paymentMethodParams) { paymentMethod, error in
if let createError = error {
resolve(Errors.createError(ErrorType.Failed, createError.localizedDescription))
resolve(Errors.createError(ErrorType.Failed, createError as NSError))
} else {
resolve(
Mappers.createResult("paymentMethod", Mappers.mapFromPaymentMethod(paymentMethod))
Expand Down Expand Up @@ -908,7 +907,7 @@ class StripeSdk: RCTEventEmitter, STPBankSelectionViewControllerDelegate, UIAdap
if let lastPaymentError = paymentIntent?.lastPaymentError {
resolve(Errors.createError(ErrorType.Unknown, lastPaymentError))
} else {
resolve(Errors.createError(ErrorType.Unknown, error?.localizedDescription))
resolve(Errors.createError(ErrorType.Unknown, error as? NSError))
}
return
}
Expand All @@ -932,7 +931,7 @@ class StripeSdk: RCTEventEmitter, STPBankSelectionViewControllerDelegate, UIAdap
if let lastSetupError = setupIntent?.lastSetupError {
resolve(Errors.createError(ErrorType.Unknown, lastSetupError))
} else {
resolve(Errors.createError(ErrorType.Unknown, error?.localizedDescription))
resolve(Errors.createError(ErrorType.Unknown, error as? NSError))
}
return
}
Expand Down