test: fix mock for useStripe #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`useStripe` returns functions rather than other hooks. In reality it doesn't return all functions from the `mockFunctions` object, but using a superset for the mock should still be fine as TS won't allow calling the functions which are not in the declared type of the hook.
|
|
|
Hi @charliecruzan-stripe , |
charliecruzan-stripe
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
change
useStripemock to return functions rather than other hooksMotivation
My unit test failed on the mock provided from this repo.
In reality
useStripedoesn't return 100% all functions listed in themockFunctionsobject, but using a superset for the mock should still be fine as TS won't allow calling the functions which are not in the declared in the return value type ofuseStripe. Returning hooks definitely is not what happens inuseStripe.Testing
No need for automated tests
Documentation