fix: expose config-plugin and add blank swift file #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Add a blank Swift file to the Xcode project for Swift compatibility. | ||
| */ | ||
| export const withNoopSwiftFile: ConfigPlugin = (config) => { |
There was a problem hiding this comment.
@cruzach does this add the needed bridging header?
There was a problem hiding this comment.
the bridging header is added by default by Expo 👍
thorsten-stripe
approved these changes
May 14, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested this library via installing by
npm, I realized theapp.plugin.jswas not being distributed with the package 😱Also added another plugin that will add a blank, no-op Swift file to the xcode project to avoid the "undefined symbols for architecture..." errors described here- https://github.com/stripe/stripe-react-native#troubleshooting - although it is not clear to me yet what the best solution for
LIBRARY_SEARCH_PATHSis.However, it doesn't look like you need to clear out all LIBRARY_SEARCH_PATHS. In particular, it looks like
"\"$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME)\""causes the problem. (I'm not sure what side effects removing that will cause, so I'm not doing that in the plugin yet)