Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create token #221

Merged
merged 18 commits into from
May 21, 2021
Merged

create token #221

merged 18 commits into from
May 21, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

@arekkubaczkowski arekkubaczkowski commented May 14, 2021

resolves #187

@arekkubaczkowski arekkubaczkowski changed the title WIP: chore: create token WIP: create token May 14, 2021
src/functions.ts Outdated Show resolved Hide resolved
src/types/Card.ts Show resolved Hide resolved
src/types/Card.ts Outdated Show resolved Hide resolved
@arekkubaczkowski arekkubaczkowski changed the title WIP: create token create token May 18, 2021
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fund some issues, PTAL

src/types/Card.ts Outdated Show resolved Hide resolved
ios/CardFieldView.swift Outdated Show resolved Hide resolved
src/types/Card.ts Outdated Show resolved Hide resolved
ios/StripeSdk.swift Show resolved Hide resolved
@thorsten-stripe
Copy link
Contributor

@arekkubaczkowski there are still some differences. Can you please make sure that both platforms have the same amount of params? And address details are not mapped on iOS. PTAL

Android
{
  "livemode": false,
  "bankAccount": null,
  "card": {
    "address": {
      "postalCode": "77063",
      "country": "US",
      "line2": "Texas",
      "state": null,
      "line1": "1459  Circle Drive",
      "city": "Houston"
    },
    "last4": "3220",
    "funding": "Credit",
    "expMonth": 12,
    "currency": null,
    "expYear": 2022,
    "brand": "Visa",
    "country": "IE"
  },
  "type": "Card",
  "created": "1621435180000",
  "id": "tok_1IsqYiG7gfqYEkPOw3a7kUfC"
}
iOS
{
  "card": {
    "expYear": 2022,
    "brand": "Visa",
    "name": null,
    "currency": null,
    "expMonth": 12,
    "last4": "3220",
    "country": "IE",
    "address": {
      "city": null,
      "country": null,
      "phone": null,
      "postalCode": null,
      "line2": null,
      "email": null,
      "line1": null,
      "name": null,
      "state": null
    },
    "funding": "Credit"
  },
  "id": "tok_1IsqVoG7gfqYEkPOu0HufCwa",
  "created": "1621435000000.0",
  "livemode": false,
  "bankAccount": null,
  "type": "Card"
}

src/types/Card.ts Show resolved Hide resolved
src/types/Card.ts Show resolved Hide resolved
@thorsten-stripe thorsten-stripe self-requested a review May 20, 2021 08:38
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing name and address.state params for createToken

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arekkubaczkowski arekkubaczkowski merged commit 6a1618a into master May 21, 2021
@arekkubaczkowski arekkubaczkowski deleted the feat/create-token branch May 21, 2021 05:11
@longhofit
Copy link

longhofit commented Jul 16, 2021

Hi tem, Is create token params was wrong from this site? https://stripe.dev/stripe-react-native/api-reference/interfaces/card.createtokenparams.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add createToken method
3 participants