Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear card params when are not valid #245

Merged
merged 5 commits into from
May 21, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

@arekkubaczkowski arekkubaczkowski commented May 20, 2021

resolves #237

@arekkubaczkowski arekkubaczkowski changed the title clear card params when are not valid fix: clear card params when are not valid May 20, 2021
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arekkubaczkowski could you include the fix for Android in this PR also?

@arekkubaczkowski
Copy link
Collaborator Author

@arekkubaczkowski could you include the fix for Android in this PR also?

Oh right, I thought it happens only on iOS for some reason

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arekkubaczkowski arekkubaczkowski merged commit 96e1c29 into master May 21, 2021
@arekkubaczkowski arekkubaczkowski deleted the fix/clearing-card-params branch May 21, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] With CardField when the card is completed and then uncomplete the flag does not change
2 participants